Skip to content

Add max_crl_entries to vault_pki_secret_backend_crl_config resource - #2423

Merged
stevendpclark merged 3 commits into
mainfrom
stevendpclark/119-fixes
Mar 6, 2025
Merged

Add max_crl_entries to vault_pki_secret_backend_crl_config resource#2423
stevendpclark merged 3 commits into
mainfrom
stevendpclark/119-fixes

Conversation

@stevendpclark

@stevendpclark stevendpclark commented Mar 6, 2025

Copy link
Copy Markdown
Contributor

Description

  • Add new 1.19 field max_crl_entries to the vault_pki_secret_backend_crl_config resource
  • Add missing Computed flag on the 1.19 PKI role field serial_number_source

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

 - Add new 1.19 field max_crl_entries to the vault_pki_secret_backend_crl_config
   resource
 - Add missing Computed flag on the 1.19 PKI role field serial_number_source
@stevendpclark
stevendpclark requested a review from a team March 6, 2025 14:49
@stevendpclark stevendpclark self-assigned this Mar 6, 2025
@stevendpclark
stevendpclark requested a review from a team as a code owner March 6, 2025 14:49
@stevendpclark
stevendpclark requested a review from MooCohen March 6, 2025 14:49
 The test was limited to 1.19 and passed in the format parameter
 to the wrong field
@stevendpclark
stevendpclark merged commit 2031ac1 into main Mar 6, 2025
@stevendpclark
stevendpclark deleted the stevendpclark/119-fixes branch March 6, 2025 15:36
@dhess

dhess commented Mar 7, 2025

Copy link
Copy Markdown

Thanks. Can we get a release ASAP? We upgraded to Vault v1.19.0 and we can't Terraform it because of this issue.

@stevendpclark

Copy link
Copy Markdown
Contributor Author

Hey @dhess, there should be a new release cut in the next week or two, sadly I can't comment more at this time.

@stevendpclark

Copy link
Copy Markdown
Contributor Author

Note #2429 was created to not fail in the future if new fields are added to the crl config.

@stevendpclark

Copy link
Copy Markdown
Contributor Author

@dhess Version 4.7.0 with the fix has been released, doc site doesn't seem to be updated yet but you should be able to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants