r/aws_appstream_directory_config: add certificate_based_auth_properties support - #44679
Conversation
% make testacc TESTS=TestAccAppStreamDirectoryConfig_basic PKG=appstream make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... make: Running acceptance tests on branch: 🌿 r/aws_appstream_directory_config-add-cert-based-auth 🌿... TF_ACC=1 go1.24.8 test ./internal/service/appstream/... -v -count 1 -parallel 20 -run='TestAccAppStreamDirectoryConfig_basic' -timeout 360m -vet=off 2025/10/16 02:28:41 Creating Terraform AWS Provider (SDKv2-style)... 2025/10/16 02:28:41 Initializing Terraform AWS Provider (SDKv2-style)... === RUN TestAccAppStreamDirectoryConfig_basic === PAUSE TestAccAppStreamDirectoryConfig_basic === CONT TestAccAppStreamDirectoryConfig_basic --- PASS: TestAccAppStreamDirectoryConfig_basic (1479.10s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/appstream 1484.096s
…dd-cert-based-auth
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
johnsonaj
left a comment
There was a problem hiding this comment.
LGTM 🚀
% make testacc TESTARGS='-run=TestAccAppStreamDirectoryConfig_basic\|TestAccAppStreamDirectoryConfig_CertificateBasedAuthParameters\|TestAccAppStreamDirectoryConfig_disappears' PKG=appstream
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 r/aws_appstream_directory_config-add-cert-based-auth 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/appstream/... -v -count 1 -parallel 20 -run=TestAccAppStreamDirectoryConfig_basic\|TestAccAppStreamDirectoryConfig_CertificateBasedAuthParameters\|TestAccAppStreamDirectoryConfig_disappears -timeout 360m -vet=off
2025/10/16 17:06:20 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/16 17:06:20 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN TestAccAppStreamDirectoryConfig_basic
=== PAUSE TestAccAppStreamDirectoryConfig_basic
=== RUN TestAccAppStreamDirectoryConfig_disappears
=== PAUSE TestAccAppStreamDirectoryConfig_disappears
=== RUN TestAccAppStreamDirectoryConfig_CertificateBasedAuthParameters
=== PAUSE TestAccAppStreamDirectoryConfig_CertificateBasedAuthParameters
=== CONT TestAccAppStreamDirectoryConfig_basic
=== CONT TestAccAppStreamDirectoryConfig_CertificateBasedAuthParameters
=== CONT TestAccAppStreamDirectoryConfig_disappears
--- PASS: TestAccAppStreamDirectoryConfig_disappears (1429.90s)
--- PASS: TestAccAppStreamDirectoryConfig_CertificateBasedAuthParameters (3258.92s)
--- PASS: TestAccAppStreamDirectoryConfig_basic (3329.57s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/appstream 3337.332s|
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
|
This functionality has been released in v6.18.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Description
Adds support to the aws_appstream_directory_config resource for certificate_based_auth_properties. This will enable user to automate the deployment and configuration of CBA.
Relations
Closes #31766
References
https://docs.aws.amazon.com/appstream2/latest/APIReference/API_CertificateBasedAuthProperties.html
https://docs.aws.amazon.com/appstream2/latest/APIReference/API_CreateDirectoryConfig.html
Output from Acceptance Testing