Skip to content

r/aws_appstream_directory_config: add certificate_based_auth_properties support - #44679

Merged
subham-ibmhc merged 6 commits into
hashicorp:mainfrom
subham-ibmhc:r/aws_appstream_directory_config-add-cert-based-auth
Oct 17, 2025
Merged

r/aws_appstream_directory_config: add certificate_based_auth_properties support#44679
subham-ibmhc merged 6 commits into
hashicorp:mainfrom
subham-ibmhc:r/aws_appstream_directory_config-add-cert-based-auth

Conversation

@subham-ibmhc

Copy link
Copy Markdown
Collaborator

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Adds support to the aws_appstream_directory_config resource for certificate_based_auth_properties. This will enable user to automate the deployment and configuration of CBA.

Relations

Closes #31766

References

https://docs.aws.amazon.com/appstream2/latest/APIReference/API_CertificateBasedAuthProperties.html
https://docs.aws.amazon.com/appstream2/latest/APIReference/API_CreateDirectoryConfig.html

Output from Acceptance Testing

% make testacc TESTS=TestAccAppStreamDirectoryConfig_basic PKG=appstream
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 r/aws_appstream_directory_config-add-cert-based-auth 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/appstream/... -v -count 1 -parallel 20 -run='TestAccAppStreamDirectoryConfig_basic'  -timeout 360m -vet=off
2025/10/16 02:28:41 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/16 02:28:41 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccAppStreamDirectoryConfig_basic
=== PAUSE TestAccAppStreamDirectoryConfig_basic
=== CONT  TestAccAppStreamDirectoryConfig_basic
--- PASS: TestAccAppStreamDirectoryConfig_basic (1479.10s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appstream  1484.096s

...

% make testacc TESTS=TestAccAppStreamDirectoryConfig_basic PKG=appstream
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 r/aws_appstream_directory_config-add-cert-based-auth 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/appstream/... -v -count 1 -parallel 20 -run='TestAccAppStreamDirectoryConfig_basic'  -timeout 360m -vet=off
2025/10/16 02:28:41 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/16 02:28:41 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccAppStreamDirectoryConfig_basic
=== PAUSE TestAccAppStreamDirectoryConfig_basic
=== CONT  TestAccAppStreamDirectoryConfig_basic
--- PASS: TestAccAppStreamDirectoryConfig_basic (1479.10s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appstream  1484.096s
@github-actions

Copy link
Copy Markdown
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions Bot added prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/appstream Issues and PRs that pertain to the appstream service. size/M Managed by automation to categorize the size of a PR. and removed prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Oct 16, 2025
@subham-ibmhc subham-ibmhc added the rnd-ind-provider rnd-ind-provider label Oct 16, 2025
Comment thread internal/service/appstream/directory_config.go Outdated
Comment thread internal/service/appstream/directory_config_test.go Outdated
@johnsonaj johnsonaj added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 16, 2025
@github-actions github-actions Bot added the size/L Managed by automation to categorize the size of a PR. label Oct 16, 2025
@johnsonaj
johnsonaj marked this pull request as ready for review October 16, 2025 23:02
@johnsonaj
johnsonaj requested a review from a team as a code owner October 16, 2025 23:02

@johnsonaj johnsonaj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS='-run=TestAccAppStreamDirectoryConfig_basic\|TestAccAppStreamDirectoryConfig_CertificateBasedAuthParameters\|TestAccAppStreamDirectoryConfig_disappears' PKG=appstream

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 r/aws_appstream_directory_config-add-cert-based-auth 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/appstream/... -v -count 1 -parallel 20  -run=TestAccAppStreamDirectoryConfig_basic\|TestAccAppStreamDirectoryConfig_CertificateBasedAuthParameters\|TestAccAppStreamDirectoryConfig_disappears -timeout 360m -vet=off
2025/10/16 17:06:20 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/16 17:06:20 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccAppStreamDirectoryConfig_basic
=== PAUSE TestAccAppStreamDirectoryConfig_basic
=== RUN   TestAccAppStreamDirectoryConfig_disappears
=== PAUSE TestAccAppStreamDirectoryConfig_disappears
=== RUN   TestAccAppStreamDirectoryConfig_CertificateBasedAuthParameters
=== PAUSE TestAccAppStreamDirectoryConfig_CertificateBasedAuthParameters
=== CONT  TestAccAppStreamDirectoryConfig_basic
=== CONT  TestAccAppStreamDirectoryConfig_CertificateBasedAuthParameters
=== CONT  TestAccAppStreamDirectoryConfig_disappears
--- PASS: TestAccAppStreamDirectoryConfig_disappears (1429.90s)
--- PASS: TestAccAppStreamDirectoryConfig_CertificateBasedAuthParameters (3258.92s)
--- PASS: TestAccAppStreamDirectoryConfig_basic (3329.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appstream	3337.332s

@subham-ibmhc
subham-ibmhc merged commit 13b6503 into hashicorp:main Oct 17, 2025
44 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions Bot added this to the v6.18.0 milestone Oct 17, 2025
@github-actions

Copy link
Copy Markdown
Contributor

This functionality has been released in v6.18.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions

Copy link
Copy Markdown
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. rnd-ind-provider rnd-ind-provider service/appstream Issues and PRs that pertain to the appstream service. size/L Managed by automation to categorize the size of a PR. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement]: Parameter to enable Certificate-based-authentication in the directory configuration of Appstream

2 participants