browser: Add frameLocator() method - #5487
Merged
Merged
Conversation
pkalsi97
requested review from
joanlopez and
mstoykov
and removed request for
a team
December 11, 2025 11:51
frameLocator() method to Page, Frame, Locator and FrameLocator objectsframeLocator() method
pkalsi97
temporarily deployed
to
azure-trusted-signing
January 6, 2026 11:20 — with
GitHub Actions
Inactive
pkalsi97
temporarily deployed
to
azure-trusted-signing
January 6, 2026 11:21 — with
GitHub Actions
Inactive
ankur22
self-requested a review
January 15, 2026 14:15
ankur22
previously approved these changes
Jan 15, 2026
ankur22
left a comment
Contributor
There was a problem hiding this comment.
LGTM 🚀 Thanks for this change!
Left some minor things that would be good if they were addressed but functionally looks correct to me.
Contributor
Author
|
@ankur22 Thanks for the review, i have addressed the above. :) i have two concerns
|
pkalsi97
temporarily deployed
to
azure-trusted-signing
January 16, 2026 09:18 — with
GitHub Actions
Inactive
pkalsi97
temporarily deployed
to
azure-trusted-signing
January 16, 2026 09:20 — with
GitHub Actions
Inactive
pkalsi97
temporarily deployed
to
azure-trusted-signing
January 16, 2026 11:59 — with
GitHub Actions
Inactive
pkalsi97
temporarily deployed
to
azure-trusted-signing
January 16, 2026 12:01 — with
GitHub Actions
Inactive
ankur22
approved these changes
Jan 19, 2026
ankur22
temporarily deployed
to
azure-trusted-signing
January 19, 2026 10:16 — with
GitHub Actions
Inactive
ankur22
temporarily deployed
to
azure-trusted-signing
January 19, 2026 10:18 — with
GitHub Actions
Inactive
mstoykov
approved these changes
Jan 19, 2026
16 tasks
joanlopez
added a commit
to grafana/k6-docs
that referenced
this pull request
Feb 10, 2026
8 tasks
joanlopez
added a commit
to grafana/k6-docs
that referenced
this pull request
Feb 10, 2026
joanlopez
added a commit
to grafana/k6-docs
that referenced
this pull request
Feb 10, 2026
8 tasks
joanlopez
added a commit
to grafana/k6-docs
that referenced
this pull request
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR Add
frameLocator()method to Page, Frame, Locator, and FrameLocator objects. This is a shorthand forlocator(selector).contentFrame()providing a more concise API for working with iframes.Usage
Why?
Issue #5177 Describes the need for a convince method.
Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)
Closes #5177