Skip to content

browser: add page.on('requestfinished') event handler - #5486

Merged
ankur22 merged 1 commit into
grafana:masterfrom
pkalsi97:feat/4300
Jan 15, 2026
Merged

browser: add page.on('requestfinished') event handler#5486
ankur22 merged 1 commit into
grafana:masterfrom
pkalsi97:feat/4300

Conversation

@pkalsi97

@pkalsi97 pkalsi97 commented Dec 11, 2025

Copy link
Copy Markdown
Contributor

What?

Implements the page.on('requestfinished') event handler that fires when a network request successfully completes (receives a response).

  • closely followed the implementation of page.on('request') and page.on('response') events.
  • Added integration test
  • Added example script

Why?

Reasons mentioned in the issue #4300

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

Closes: #4300
Parent: #4232

@pkalsi97
pkalsi97 requested a review from a team as a code owner December 11, 2025 10:56
@pkalsi97
pkalsi97 requested review from joanlopez and mstoykov and removed request for a team December 11, 2025 10:56
@pkalsi97
pkalsi97 temporarily deployed to azure-trusted-signing January 6, 2026 11:20 — with GitHub Actions Inactive
@pkalsi97
pkalsi97 temporarily deployed to azure-trusted-signing January 6, 2026 11:22 — with GitHub Actions Inactive

@mstoykov mstoykov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

This one also looks really well, and I do not see any problems with its test :)

@ankur22
ankur22 self-requested a review January 15, 2026 14:15

@ankur22 ankur22 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 awesome work again! 🚀

@ankur22
ankur22 merged commit d73b029 into grafana:master Jan 15, 2026
41 checks passed
@ankur22

ankur22 commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

@pkalsi97 would we super useful if you could add type definition and documentation updates 🙇

@ankur22 ankur22 added this to the v1.6.0 milestone Jan 15, 2026
@pkalsi97

Copy link
Copy Markdown
Contributor Author

@ankur22 Thanks :) will do it shortly.

@pkalsi97

Copy link
Copy Markdown
Contributor Author

@ankur22 i have added docs and types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement page.on('requestfinished')

3 participants