browser: add page.on('requestfinished') event handler - #5486
Merged
Conversation
pkalsi97
requested review from
joanlopez and
mstoykov
and removed request for
a team
December 11, 2025 10:56
pkalsi97
temporarily deployed
to
azure-trusted-signing
January 6, 2026 11:20 — with
GitHub Actions
Inactive
pkalsi97
temporarily deployed
to
azure-trusted-signing
January 6, 2026 11:22 — with
GitHub Actions
Inactive
mstoykov
approved these changes
Jan 12, 2026
mstoykov
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the PR!
This one also looks really well, and I do not see any problems with its test :)
ankur22
self-requested a review
January 15, 2026 14:15
Contributor
|
@pkalsi97 would we super useful if you could add type definition and documentation updates 🙇 |
8 tasks
Contributor
Author
|
@ankur22 Thanks :) will do it shortly. |
This was referenced Jan 15, 2026
Contributor
Author
|
@ankur22 i have added docs and types. |
baeseokjae
pushed a commit
to baeseokjae/k6
that referenced
this pull request
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Implements the
page.on('requestfinished')event handler that fires when a network request successfully completes (receives a response).page.on('request')andpage.on('response')events.Why?
Reasons mentioned in the issue #4300
Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)
Closes: #4300
Parent: #4232