Skip to content

fix(checkpoint): degrade non-array history instead of crashing resume #29195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
soroush5 wants to merge 2 commits into
base: main
Choose a base branch
from
+26 −2
Open

fix(checkpoint): degrade non-array history instead of crashing resume #29195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8e7e44
fix(checkpoint): degrade non-array history instead of crashing resume
soroush5 Sep 3, 2026
38b094e
chore: retrigger cla check after signing
soroush5 Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions packages/core/src/core/logger.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,6 +567,25 @@ describe('Logger', () => {
);
});

it.each([
['null', null],
['number', 123],
])(
'should return an empty history if history is %s instead of an array (#29194)',
async (_label: string, badHistory: unknown) => {
const taggedFilePath = path.join(
TEST_GEMINI_DIR,
'checkpoint-wrong-shape.json',
);
await fs.writeFile(
taggedFilePath,
JSON.stringify({ history: badHistory }),
);
const loadedCheckpoint = await logger.loadCheckpoint('wrong-shape');
expect(loadedCheckpoint).toEqual({ history: [] });
},
);

it('should return an empty history if logger is not initialized', async () => {
const uninitializedLogger = new Logger(
testSessionId,
Expand Down
9 changes: 7 additions & 2 deletions packages/core/src/core/logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,8 +367,13 @@ export class Logger {
parsedContent !== null &&
'history' in parsedContent
) {
// eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion
return parsedContent as Checkpoint;
const history: unknown = parsedContent.history;
// A valid-JSON file with a non-array history (crash mid-save, full
// disk, hand edit) must degrade like any other corrupt file (#29194).
if (Array.isArray(history)) {
// eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion
return parsedContent as Checkpoint;
}
}

debugLogger.warn(
Expand Down