Skip to content

fix(vscode-ide-companion): remove comma operator wrapping in activate() - #28489

Closed
kunalrawat425 wants to merge 1 commit into
google-gemini:mainfrom
kunalrawat425:kunalrawat425/fix-vscode-companion-cleanup
Closed

fix(vscode-ide-companion): remove comma operator wrapping in activate()#28489
kunalrawat425 wants to merge 1 commit into
google-gemini:mainfrom
kunalrawat425:kunalrawat425/fix-vscode-companion-cleanup

Conversation

@kunalrawat425

Copy link
Copy Markdown

Remove comma operator wrapping in activate() that leaked gemini.diff.accept and onDidChangeWorkspaceFolders Disposables, preventing proper cleanup on deactivation (closes #27790).

remove comma operator wrapping in activate() that leaked gemini.diff.accept and onDidChangeWorkspaceFolders Disposables, preventing proper cleanup on deactivation (closes google-gemini#27790)
@kunalrawat425
kunalrawat425 requested a review from a team as a code owner July 22, 2026 15:58
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a resource management issue in the vscode-ide-companion extension. By removing unnecessary comma operator wrapping during the registration of command and workspace event listeners, the extension now correctly adds these disposables to the context subscriptions, ensuring proper cleanup when the extension is deactivated.

Highlights

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions

Copy link
Copy Markdown

📊 PR Size: size/XS

  • Lines changed: 8
  • Additions: +4
  • Deletions: -4
  • Files changed: 1

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up the syntax in packages/vscode-ide-companion/src/extension.ts by removing redundant parentheses around several VS Code API calls within context.subscriptions.push. There are no review comments, and I have no additional feedback to provide.

@github-actions

Copy link
Copy Markdown

You already have 7 pull requests open. Please work on getting existing PRs merged before opening more.

@github-actions github-actions Bot closed this Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs An extra small PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(vscode-ide-companion): comma operator in activate() leaks two Disposables (gemini.diff.accept, onDidChangeWorkspaceFolders)

1 participant