fix(vscode-ide-companion): remove comma operator wrapping in activate() - #28489
fix(vscode-ide-companion): remove comma operator wrapping in activate()#28489kunalrawat425 wants to merge 1 commit into
Conversation
remove comma operator wrapping in activate() that leaked gemini.diff.accept and onDidChangeWorkspaceFolders Disposables, preventing proper cleanup on deactivation (closes google-gemini#27790)
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a resource management issue in the vscode-ide-companion extension. By removing unnecessary comma operator wrapping during the registration of command and workspace event listeners, the extension now correctly adds these disposables to the context subscriptions, ensuring proper cleanup when the extension is deactivated. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
📊 PR Size: size/XS
|
There was a problem hiding this comment.
Code Review
This pull request cleans up the syntax in packages/vscode-ide-companion/src/extension.ts by removing redundant parentheses around several VS Code API calls within context.subscriptions.push. There are no review comments, and I have no additional feedback to provide.
|
You already have 7 pull requests open. Please work on getting existing PRs merged before opening more. |
Remove comma operator wrapping in activate() that leaked gemini.diff.accept and onDidChangeWorkspaceFolders Disposables, preventing proper cleanup on deactivation (closes #27790).