fix(cli): add gemini-3.5-flash to model selector for all users (#28483) - #28485
fix(cli): add gemini-3.5-flash to model selector for all users (#28483)#28485kunalrawat425 wants to merge 4 commits into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a visibility issue for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
📊 PR Size: size/L
|
There was a problem hiding this comment.
Code Review
This pull request introduces several enhancements and bug fixes across the repository. Key changes include adding an autoCompressOnOverflow setting to automatically compress chat history when approaching context limits, ensuring gemini-3.5-flash is always available as a selectable model, sanitizing trailing punctuation from URLs in error messages, and fixing skill description parsing for single-line or colon-containing descriptions. Feedback on these changes highlights that the background auto-compression task in useGeminiStream.ts lacks proper cancellation handling and should accept and propagate an AbortSignal to prevent dangling operations.
2015e83 to
f932f10
Compare
|
I have split the other unrelated fixes into separate focused pull requests:
|
…#28483) gemini-3.5-flash was absent from the manual model picker for users not enrolled in the GEMINI_3_5_FLASH_GA_LAUNCHED experiment, because buildAvailableModels only listed DEFAULT_GEMINI_FLASH_MODEL (which remains gemini-2.5-flash until the flag fires). Fix: always include DEFAULT_GEMINI_3_5_FLASH_MODEL as an explicit option in the legacy-path manualOptions list, with a deduplication guard so it does not appear twice when the flag has already promoted it to the default flash model. Also export DEFAULT_GEMINI_3_5_FLASH_MODEL from the core package index so it can be consumed by CLI code without reaching into internal package paths.
…del selector This adds constants, aliases, definitions, and resolutions for gemini-3.6-flash and gemini-3.5-flash-lite, surfacing them correctly in the manual picker and model dialog, and regenerates settings schema and documentation.
When the GEMINI_3_5_FLASH_GA_LAUNCHED experiment flag fires, DEFAULT_GEMINI_FLASH_MODEL is mutated to 'gemini-3.5-flash', which equals DEFAULT_GEMINI_3_5_FLASH_MODEL. Without the guard the legacy options list in ModelDialog showed the same model entry twice. Apply the same conditional-spread dedup guard used in acpUtils.ts.
bb09dcf to
be4b3c6
Compare
|
Good question — the short answer is no, this PR only affects the manual model picker, not the auto router. The
What this PR does is narrower: it adds If the intent is also for auto to consider |
|
Flagging for maintainer attention — this PR is ready for review:
The scope question from @hi-fox has been answered. Happy to make any changes the team needs. |
|
Is there a way to see where the PR ranks in maintainers' triage? Or are they chosen at random |
|
Hi there! Thank you for your interest in contributing to Gemini CLI. To ensure we maintain high code quality and focus on our prioritized roadmap, we only guarantee review and consideration of pull requests for issues that are explicitly labeled as 'help wanted'. This PR will be closed in 7 days if it remains without that designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding. |
|
This pull request is being closed as it has been open for 14 days without a 'help wanted' designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding. |
|
This type of triage is abysmal. Someone performed free labor to improve a company's product and it's been ignored |
Problem
Fixes #28483 — users on v0.51.0 cannot select
gemini-3.5-flashorgemini-3.6-flashfrom the model selector.Root cause:
buildAvailableModelsandModelDialog(legacy paths) only surfaceDEFAULT_GEMINI_FLASH_MODELwhich stays asgemini-2.5-flashuntil the backendGEMINI_3_5_FLASH_GA_LAUNCHEDexperiment flag fires. Users not yet enrolled in the rollout cannot seegemini-3.5-flashas a selectable option, andgemini-3.6-flashwas not defined in the codebase at all.Fix
Add
DEFAULT_GEMINI_3_5_FLASH_MODEL(gemini-3.5-flash) to the legacy-pathmanualOptionslist in bothacpUtils.tsandModelDialog.tsx, guarded by a deduplication check so it does not appear twice once the GA flag promotes it toDEFAULT_GEMINI_FLASH_MODEL.Add
gemini-3.6-flashandgemini-3.5-flash-liteas new model constants and surface them in the legacy model selector in bothacpUtils.tsandModelDialog.tsx,defaultModelConfigs.ts,VALID_GEMINI_MODELS, and documentation.Guard
resolveModel()to prevent overriding an explicitly-setgemini-3.6-flashback to the default flash model.Changes
packages/core/src/config/models.tsDEFAULT_GEMINI_3_5_FLASH_MODEL,DEFAULT_GEMINI_3_6_FLASH_MODEL,DEFAULT_GEMINI_3_5_FLASH_LITE_MODELconstants; add toVALID_GEMINI_MODELS; guardresolveModelpackages/core/src/config/defaultModelConfigs.tsgemini-3.5-flash,gemini-3.6-flash,gemini-3.5-flash-litepackages/core/index.tspackages/cli/src/acp/acpUtils.tsmanualOptionswith dedup guard forgemini-3.5-flashpackages/cli/src/ui/components/ModelDialog.tsxgemini-3.5-flashpackages/cli/src/acp/acpUtils.test.tspackages/core/src/config/models.test.tsresolveModelguardschemas/settings.schema.jsondocs/reference/configuration.mdTest plan
npx vitest run packages/cli/src/acp/acpUtils.test.ts packages/core/src/config/models.test.ts— 98 tests passnpm run build— clean build, no type errors introduced by this PRgemini→/model→ verifygemini-3.5-flash,gemini-3.6-flash, andgemini-3.5-flash-liteappear in the list