Add regression test: blob content readable next to a submodule - #243
Merged
Conversation
Reading a blob's content in a tree that also contains a submodule used to fail (issue #12) because the tree parser did not recognize the "commit" entry type. This has since been fixed, but there was no test covering the scenario, so add one to prevent a regression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue #12 reported that a submodule entry in a tree made it impossible to read the content of sibling blobs, because the tree parser's regex (
/(blob|tree)/A) didn't recognize thecommitentry type used for submodules.This has already been fixed in the current codebase:
TreeParseracceptsblob,treeandcommitentry types.Tree::initialize()builds aCommitReferencefor submodule entries instead of failing.Blob::getContent()reads content directly viacat-file -p <hash>, independent of tree parsing.I verified against the test fixture (which already contains a
barbazsubmodule alongside regular files) that reading blob content next to a submodule works correctly. This PR only adds a regression test to lock in that behavior, since there wasn't one covering this exact scenario.Test plan
testGetContentSiblingToSubmoduleinBlobTest.phpCloses #12