fix(auth): emit AuthResult on sign-in success and fix MFA tooltip auto-open#2326
Merged
Merged
Conversation
demolaf
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the authentication state management to provide more detailed feedback upon successful sign-in. Specifically, it introduces updateAuthStateWithResult in FirebaseAuthUI to transition the state to AuthState.Success (including AuthResult and user details) rather than simply returning to Idle. These changes are propagated across Anonymous, Email, and OAuth providers, with corresponding updates to unit tests. The PR also includes UI adjustments to tooltip visibility. Feedback was provided to revert the USE_AUTH_EMULATOR flag in the demo app to false to ensure it remains functional for users without a local emulator setup.
mikehardy
reviewed
May 20, 2026
mikehardy
approved these changes
May 20, 2026
mikehardy
left a comment
mikehardy
left a comment
Contributor
There was a problem hiding this comment.
I don't appear to have the ability to resolve my comment threads but I consider them resolved now. I'm also not sure if I have repo-authority such that my approval counts but it was a real review :-). +1, looks good
dackers86
approved these changes
May 20, 2026
Merged
demolaf
added a commit
that referenced
this pull request
Jun 16, 2026
…o-open (#2326) * fix(auth): update AuthState to reflect success or idle based on user result * updates * updates * refactor: rename auth user state handler
demolaf
added a commit
that referenced
this pull request
Jun 29, 2026
…o-open (#2326) * fix(auth): update AuthState to reflect success or idle based on user result * updates * updates * refactor: rename auth user state handler
demolaf
added a commit
that referenced
this pull request
Jul 1, 2026
…o-open (#2326) * fix(auth): update AuthState to reflect success or idle based on user result * updates * updates * refactor: rename auth user state handler
demolaf
added a commit
that referenced
this pull request
Jul 1, 2026
…o-open (#2326) * fix(auth): update AuthState to reflect success or idle based on user result * updates * updates * refactor: rename auth user state handler
demolaf
added a commit
that referenced
this pull request
Jul 2, 2026
…o-open (#2326) * fix(auth): update AuthState to reflect success or idle based on user result * updates * updates * refactor: rename auth user state handler
demolaf
added a commit
to demolaf/FirebaseUI-Android
that referenced
this pull request
Jul 2, 2026
…o-open (firebase#2326) * fix(auth): update AuthState to reflect success or idle based on user result * updates * updates * refactor: rename auth user state handler
demolaf
added a commit
that referenced
this pull request
Jul 2, 2026
…ng (#2354) * fix(auth): improve user identifier retrieval (#2314) * fix(auth): improve user identifier retrieval * updates * fix: ensure that when selecting phone or email, it routes straight to that screen (#2311) * fix: use secondary app if it is passed into FirebaseAuthUI (#2313) * fix(auth): make AuthException messages customisable via AuthUIStringProvider (#2320) * fix(auth): preserve linkDomain in email link ActionCodeSettings (#2321) * fix(auth): log out before Facebook sign-in to clear stale cached token (#2322) Co-authored-by: russellwheatley <russellwheatley85@gmail.com> * Fix typo in README (#2325) * fix(auth): emit AuthResult on sign-in success and fix MFA tooltip auto-open (#2326) * fix(auth): update AuthState to reflect success or idle based on user result * updates * updates * refactor: rename auth user state handler * fix(auth): expose slot parameters through FirebaseAuthScreen (#2328) * fix(auth): add configurable params for custom UI - AuthMethodPicker - EmailAuth - PhoneAuth - MFA Enrollment & Challenge * fix(auth): add demo activities for email and phone authentication with customizable UI * updates * updates * feat(auth): add customMethodPickerTermsContent slot to FirebaseAuthScreen (#2330) * feat(auth): add termsContent slot to AuthMethodPicker for custom ToS UI * feat(auth): add termsAccepted parameter to AuthMethodPicker for consent handling * update example * updates * updates * updates * feat(auth): add isCredentialLinkingEnabled for authenticated users (#2319) * feat(auth): add isCredentialLinkingEnabled for authenticated non-anonymous users * t feat(app): add CredentialLinkingDemoActivity to sample app # Conflicts: # app/src/main/AndroidManifest.xml * updates * feat(auth): surface GIdP password policy violations with actionable error messages (#2333) * feat(auth): handle GIdP password policy violations with specific error messages * updates * updates * cleanup * fix(auth): allow SAML providers in AuthUIConfiguration (#2331) * fix(auth): allow saml. prefixed provider IDs in AuthUIConfiguration validation * updates * feat(auth): add reauthentication flow with automatic operation retry (#2332) * wip # Conflicts: # auth/src/main/java/com/firebase/ui/auth/configuration/auth_provider/EmailAuthProvider+FirebaseAuthUI.kt # auth/src/main/java/com/firebase/ui/auth/ui/screens/FirebaseAuthScreen.kt * feat(auth): add reauthentication flow with automatic operation retry Adds AuthState.ReauthenticationRequired, withReauth(), and createReauthFlow() to support sensitive operations that require recent sign-in. FirebaseAuthUI.delete() and withReauth() automatically catch FirebaseAuthRecentLoginRequiredException, emit the new state carrying the original operation as retryOperation, and FirebaseAuthScreen presents a ModalBottomSheet overlay scoped to the user's linked providers — no navigation away from the authenticated screen. On successful reauthentication the original operation is retried automatically. * test(auth): add e2e tests for reauthentication flow UI * updates * fix reviews * update README * feat(auth): implement `legacyFetchSignInWithEmail` configuration option (#2316) * feat(auth): implement legacyFetchSignInWithEmail configuration option * test: write tests for legacyFetchSignInWithEmail * fix(pr): address reviewer feedback on email recovery routing * refactor(pr): address reviewer feedback on legacy email recovery * fix: cancellation callback + test * chore: ignore kotlin cache * chore: run demo app script from command line --------- Co-authored-by: demolaf <demolafadumo@gmail.com> * fix(auth): replace hardcoded loading state strings with translatable string resources (#2339) * feat(auth): add localized loading messages for various sign-in states * updates * feat(auth): update sign-in methods to use AuthUIConfiguration for localized messages * refactor: use periods to represent ellipsis not the unicode character * refactor: use qualifiers, not base values in tests * fix(auth): remember authStateFlow() to avoid resubscribing on every recomposition * fix(auth): remember authStateFlow() in EmailAuthScreen to avoid resubscribing * docs(auth): note FirebaseAuthUI.create() instability inside composables --------- Co-authored-by: Russell Wheatley <russellwheatley85@gmail.com> Co-authored-by: Nillan Sivarasa <nillan.sivarasa@gmail.com>
thatfiredev
pushed a commit
that referenced
this pull request
Jul 9, 2026
…o-open (#2326) * fix(auth): update AuthState to reflect success or idle based on user result * updates * updates * refactor: rename auth user state handler
thatfiredev
pushed a commit
that referenced
this pull request
Jul 9, 2026
…ng (#2354) * fix(auth): improve user identifier retrieval (#2314) * fix(auth): improve user identifier retrieval * updates * fix: ensure that when selecting phone or email, it routes straight to that screen (#2311) * fix: use secondary app if it is passed into FirebaseAuthUI (#2313) * fix(auth): make AuthException messages customisable via AuthUIStringProvider (#2320) * fix(auth): preserve linkDomain in email link ActionCodeSettings (#2321) * fix(auth): log out before Facebook sign-in to clear stale cached token (#2322) Co-authored-by: russellwheatley <russellwheatley85@gmail.com> * Fix typo in README (#2325) * fix(auth): emit AuthResult on sign-in success and fix MFA tooltip auto-open (#2326) * fix(auth): update AuthState to reflect success or idle based on user result * updates * updates * refactor: rename auth user state handler * fix(auth): expose slot parameters through FirebaseAuthScreen (#2328) * fix(auth): add configurable params for custom UI - AuthMethodPicker - EmailAuth - PhoneAuth - MFA Enrollment & Challenge * fix(auth): add demo activities for email and phone authentication with customizable UI * updates * updates * feat(auth): add customMethodPickerTermsContent slot to FirebaseAuthScreen (#2330) * feat(auth): add termsContent slot to AuthMethodPicker for custom ToS UI * feat(auth): add termsAccepted parameter to AuthMethodPicker for consent handling * update example * updates * updates * updates * feat(auth): add isCredentialLinkingEnabled for authenticated users (#2319) * feat(auth): add isCredentialLinkingEnabled for authenticated non-anonymous users * t feat(app): add CredentialLinkingDemoActivity to sample app # Conflicts: # app/src/main/AndroidManifest.xml * updates * feat(auth): surface GIdP password policy violations with actionable error messages (#2333) * feat(auth): handle GIdP password policy violations with specific error messages * updates * updates * cleanup * fix(auth): allow SAML providers in AuthUIConfiguration (#2331) * fix(auth): allow saml. prefixed provider IDs in AuthUIConfiguration validation * updates * feat(auth): add reauthentication flow with automatic operation retry (#2332) * wip # Conflicts: # auth/src/main/java/com/firebase/ui/auth/configuration/auth_provider/EmailAuthProvider+FirebaseAuthUI.kt # auth/src/main/java/com/firebase/ui/auth/ui/screens/FirebaseAuthScreen.kt * feat(auth): add reauthentication flow with automatic operation retry Adds AuthState.ReauthenticationRequired, withReauth(), and createReauthFlow() to support sensitive operations that require recent sign-in. FirebaseAuthUI.delete() and withReauth() automatically catch FirebaseAuthRecentLoginRequiredException, emit the new state carrying the original operation as retryOperation, and FirebaseAuthScreen presents a ModalBottomSheet overlay scoped to the user's linked providers — no navigation away from the authenticated screen. On successful reauthentication the original operation is retried automatically. * test(auth): add e2e tests for reauthentication flow UI * updates * fix reviews * update README * feat(auth): implement `legacyFetchSignInWithEmail` configuration option (#2316) * feat(auth): implement legacyFetchSignInWithEmail configuration option * test: write tests for legacyFetchSignInWithEmail * fix(pr): address reviewer feedback on email recovery routing * refactor(pr): address reviewer feedback on legacy email recovery * fix: cancellation callback + test * chore: ignore kotlin cache * chore: run demo app script from command line --------- Co-authored-by: demolaf <demolafadumo@gmail.com> * fix(auth): replace hardcoded loading state strings with translatable string resources (#2339) * feat(auth): add localized loading messages for various sign-in states * updates * feat(auth): update sign-in methods to use AuthUIConfiguration for localized messages * refactor: use periods to represent ellipsis not the unicode character * refactor: use qualifiers, not base values in tests * fix(auth): remember authStateFlow() to avoid resubscribing on every recomposition * fix(auth): remember authStateFlow() in EmailAuthScreen to avoid resubscribing * docs(auth): note FirebaseAuthUI.create() instability inside composables --------- Co-authored-by: Russell Wheatley <russellwheatley85@gmail.com> Co-authored-by: Nillan Sivarasa <nillan.sivarasa@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2318 .
All providers called
updateAuthState(Idle)after sign-in, so the onlyAuthState.Successcame from Firebase'sAuthStateListenerwhich never carries anAuthResult. Theresult?.letguard inFirebaseAuthScreenthen silently blockedonSignInSuccessevery time.Fix: emit
AuthState.Successwith the realAuthResultvia a sharedupdateAuthStateWithResult()helper. Also fixes MFA tooltip auto-opening when disabled.