Skip to content

fix(auth): make AuthException messages customisable via AuthUIStringProvider#2320

Merged
russellwheatley merged 2 commits into
version-10.0.0-beta03from
exception-translations
May 15, 2026
Merged

fix(auth): make AuthException messages customisable via AuthUIStringProvider#2320
russellwheatley merged 2 commits into
version-10.0.0-beta03from
exception-translations

Conversation

@demolaf

@demolaf demolaf commented May 11, 2026

Copy link
Copy Markdown
Member

Fixes #1815AuthException messages were hardcoded in English with no
way for apps to customise or translate them.

From strings.xml in consumers app

Screenshot 2026-05-11 at 18 27 09

Expected Behavior

Screenshot_1778520434

@demolaf demolaf marked this pull request as draft May 11, 2026 13:50
@demolaf demolaf changed the base branch from master to version-10.0.0-beta03 May 11, 2026 13:50

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables custom error message mapping in AuthException by integrating the AuthUIStringProvider. The changes include updating the AuthException.from factory method to accept a string provider, adding new error message properties to the AuthUIStringProvider interface, and updating various UI screens and providers to pass the context or string provider during exception handling. Feedback focuses on correcting a regression in fallback error messages for disabled users, ensuring consistent precedence where the custom provider overrides SDK messages, and utilizing the local stringProvider in UI screens instead of the context overload to prevent ignoring user-configured custom providers.

Comment thread auth/src/main/java/com/firebase/ui/auth/AuthException.kt Outdated
Comment thread auth/src/main/java/com/firebase/ui/auth/ui/screens/email/EmailAuthScreen.kt Outdated
Comment thread auth/src/main/java/com/firebase/ui/auth/ui/screens/email/EmailAuthScreen.kt Outdated
Comment thread auth/src/main/java/com/firebase/ui/auth/ui/screens/email/EmailAuthScreen.kt Outdated
Comment thread auth/src/main/java/com/firebase/ui/auth/ui/screens/phone/PhoneAuthScreen.kt Outdated
Comment thread auth/src/main/java/com/firebase/ui/auth/AuthException.kt Outdated
@demolaf demolaf marked this pull request as ready for review May 11, 2026 17:16
@demolaf demolaf requested a review from russellwheatley May 12, 2026 08:52

@russellwheatley russellwheatley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 👍

@russellwheatley russellwheatley merged commit e599365 into version-10.0.0-beta03 May 15, 2026
5 checks passed
@russellwheatley russellwheatley deleted the exception-translations branch May 15, 2026 09:01
demolaf added a commit to demolaf/FirebaseUI-Android that referenced this pull request Jul 2, 2026
demolaf added a commit that referenced this pull request Jul 2, 2026
…ng (#2354)

* fix(auth): improve user identifier retrieval (#2314)

* fix(auth): improve user identifier retrieval

* updates

* fix: ensure that when selecting phone or email, it routes straight to that screen (#2311)

* fix: use secondary app if it is passed into FirebaseAuthUI (#2313)

* fix(auth): make AuthException messages customisable via AuthUIStringProvider (#2320)

* fix(auth): preserve linkDomain in email link ActionCodeSettings (#2321)

* fix(auth): log out before Facebook sign-in to clear stale cached token (#2322)

Co-authored-by: russellwheatley <russellwheatley85@gmail.com>

* Fix typo in README (#2325)

* fix(auth): emit AuthResult on sign-in success and fix MFA tooltip auto-open (#2326)

* fix(auth): update AuthState to reflect success or idle based on user result

* updates

* updates

* refactor: rename auth user state handler

* fix(auth): expose slot parameters through FirebaseAuthScreen (#2328)

* fix(auth): add configurable params for custom UI

- AuthMethodPicker
- EmailAuth
- PhoneAuth
- MFA Enrollment & Challenge

* fix(auth): add demo activities for email and phone authentication with customizable UI

* updates

* updates

* feat(auth): add customMethodPickerTermsContent slot to FirebaseAuthScreen (#2330)

* feat(auth): add termsContent slot to AuthMethodPicker for custom ToS UI

* feat(auth): add termsAccepted parameter to AuthMethodPicker for consent handling

* update example

* updates

* updates

* updates

* feat(auth): add isCredentialLinkingEnabled for authenticated users (#2319)

* feat(auth): add isCredentialLinkingEnabled for authenticated non-anonymous users

* t feat(app): add CredentialLinkingDemoActivity to sample app

# Conflicts:
#	app/src/main/AndroidManifest.xml

* updates

* feat(auth): surface GIdP password policy violations with actionable error messages (#2333)

* feat(auth): handle GIdP password policy violations with specific error messages

* updates

* updates

* cleanup

* fix(auth): allow SAML providers in AuthUIConfiguration (#2331)

* fix(auth): allow saml. prefixed provider IDs in AuthUIConfiguration validation

* updates

* feat(auth): add reauthentication flow with automatic operation retry (#2332)

* wip

# Conflicts:
#	auth/src/main/java/com/firebase/ui/auth/configuration/auth_provider/EmailAuthProvider+FirebaseAuthUI.kt
#	auth/src/main/java/com/firebase/ui/auth/ui/screens/FirebaseAuthScreen.kt

* feat(auth): add reauthentication flow with automatic operation retry

Adds AuthState.ReauthenticationRequired, withReauth(), and createReauthFlow()
to support sensitive operations that require recent sign-in. FirebaseAuthUI.delete()
and withReauth() automatically catch FirebaseAuthRecentLoginRequiredException,
emit the new state carrying the original operation as retryOperation, and
FirebaseAuthScreen presents a ModalBottomSheet overlay scoped to the user's
linked providers — no navigation away from the authenticated screen. On successful
reauthentication the original operation is retried automatically.

* test(auth): add e2e tests for reauthentication flow UI

* updates

* fix reviews

* update README

* feat(auth): implement `legacyFetchSignInWithEmail` configuration option (#2316)

* feat(auth): implement legacyFetchSignInWithEmail configuration option

* test: write tests for legacyFetchSignInWithEmail

* fix(pr): address reviewer feedback on email recovery routing

* refactor(pr): address reviewer feedback on legacy email recovery

* fix: cancellation callback + test

* chore: ignore kotlin cache

* chore: run demo app script from command line

---------

Co-authored-by: demolaf <demolafadumo@gmail.com>

* fix(auth): replace hardcoded loading state strings with translatable string resources (#2339)

* feat(auth): add localized loading messages for various sign-in states

* updates

* feat(auth): update sign-in methods to use AuthUIConfiguration for localized messages

* refactor: use periods to represent ellipsis not the unicode character

* refactor: use qualifiers, not base values in tests

* fix(auth): remember authStateFlow() to avoid resubscribing on every recomposition

* fix(auth): remember authStateFlow() in EmailAuthScreen to avoid resubscribing

* docs(auth): note FirebaseAuthUI.create() instability inside composables

---------

Co-authored-by: Russell Wheatley <russellwheatley85@gmail.com>
Co-authored-by: Nillan Sivarasa <nillan.sivarasa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't customize 'account disabled' string in auth UI

2 participants