Skip to content

[main] Update dependencies from dotnet/arcade#5437

Merged
dreddy-work merged 6 commits into
mainfrom
darc-main-5b650eca-e320-4b5a-adc6-4cd404861326
Aug 25, 2021
Merged

[main] Update dependencies from dotnet/arcade#5437
dreddy-work merged 6 commits into
mainfrom
darc-main-5b650eca-e320-4b5a-adc6-4cd404861326

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Aug 17, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: b9a1a4bb-2302-4987-3b3d-08d8b8050dda
  • Build: 20210824.3
  • Date Produced: 8/24/2021 11:29 PM
  • Commit: 3dd12f0a1d25fa29b84e38b7d2345a693f4ae45e
  • Branch: refs/heads/main
Microsoft Reviewers: Open in CodeFlow

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
a1531c1 
…813.4

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.GenFacades , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21412.1 -> To Version 6.0.0-beta.21413.4
@dotnet-maestro
dotnet-maestro Bot requested a review from a team as a code owner August 17, 2021 12:10
ghost
ghost previously approved these changes Aug 17, 2021
View reviewed changes

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go, you big red fire engine!

@dreddy-work

dreddy-work commented Aug 17, 2021

Copy link
Copy Markdown
Member

@mmitche , Build is broken with this change. Seems runtime reference is not available.

@mmitche

mmitche commented Aug 17, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

@dotnet/dnceng I think it might the implicit usings change in arcade. What's the resolution?

@michellemcdaniel

michellemcdaniel commented Aug 17, 2021 •
edited
Loading

Copy link
Copy Markdown

To disable implicit usings add:

<PropertyGroup>
  <DisableImplicitNamespaceImports>true</DisableImplicitNamespaceImports>
  <DisableImplicitNamespaceImports_DotNet>true</DisableImplicitNamespaceImports_DotNet>
</PropertyGroup>

to Directory.Build.Props

@RussKie

RussKie commented Aug 18, 2021

Copy link
Copy Markdown
Contributor

@adiaaida this doesn't sound right. Implicit usings are being re-done in dotnet/sdk#19521 and dotnet/sdk#19599, and these properties you mentioned are (should be) no longer relevant...

@RussKie

This comment has been minimized.

Sign in to view
@RussKie RussKie self-assigned this Aug 18, 2021
@RussKie RussKie mentioned this pull request Aug 18, 2021
Merged
@RussKie

RussKie commented Aug 18, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

I take my words back, it looks like a new regression caused by dotnet/sdk#19599 dotnet/arcade#7745

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
c05d5a1 
…817.1

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.GenFacades , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21412.1 -> To Version 6.0.0-beta.21417.1
@pranavkm

pranavkm commented Aug 18, 2021

Copy link
Copy Markdown
Contributor

I think you're running in to https://github.com/dotnet/arcade/pull/7745/files. Arcade turned off implicit imports.

@RussKie RussKie mentioned this pull request Aug 18, 2021
Merged
1 task
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
6c97c3b 
…818.12

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.GenFacades , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21412.1 -> To Version 6.0.0-beta.21418.12
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
04badb9 
…819.2

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.GenFacades , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21412.1 -> To Version 6.0.0-beta.21419.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
4d97d04 
…820.4

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.GenFacades , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21412.1 -> To Version 6.0.0-beta.21420.4
@dreddy-work

dreddy-work commented Aug 23, 2021

Copy link
Copy Markdown
Member

FYI - @mmitche, we are not taking any of the arcade updates until the regression due to "global/implicit usings" resolved.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
eb57240 
…824.3

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.GenFacades , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21412.1 -> To Version 6.0.0-beta.21424.3
@MattGal

MattGal commented Aug 25, 2021

Copy link
Copy Markdown
Member

FYI - @mmitche, we are not taking any of the arcade updates until the regression due to "global/implicit usings" resolved.

Note while in this state, you can also use the darc CLI to disable the specific subscription to prevent PRs from being created

@dreddy-work
dreddy-work merged commit 443f022 into main Aug 25, 2021
@dreddy-work
dreddy-work deleted the darc-main-5b650eca-e320-4b5a-adc6-4cd404861326 branch August 25, 2021 17:06
@ghost ghost locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

@RussKie RussKie

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dreddy-work @mmitche @michellemcdaniel @RussKie @pranavkm @MattGal