Skip to content

Work around implicit usings breaking change#7745

Merged
tmat merged 1 commit into
mainfrom
dev/tmat/implicitusings
Aug 12, 2021
Merged

Work around implicit usings breaking change#7745
tmat merged 1 commit into
mainfrom
dev/tmat/implicitusings

Conversation

@tmat

@tmat tmat commented Aug 12, 2021

Copy link
Copy Markdown
Member

Work around dotnet/sdk#19521

Without this workaround Arcade update breaks builds, e.g. https://github.com/dotnet/sourcelink/pull/729/checks?check_run_id=3280200935

@markwilkie

Copy link
Copy Markdown
Contributor

makes sense to me - adding @mmitche as an fyi

@tmat
tmat enabled auto-merge (squash) August 12, 2021 18:41
@tmat
tmat merged commit 5f00dd2 into main Aug 12, 2021
@dougbu

dougbu commented Aug 12, 2021

Copy link
Copy Markdown
Contributor

This is going to break dotnet/aspnetcore because we are intentionally ahead of Arcade on SDK versions and have already reacted to the implicit usings change. /cc @dotnet/aspnet-build

@markwilkie

markwilkie commented Aug 12, 2021

Copy link
Copy Markdown
Contributor

What does it mean for y'all @dougbu when the implicit using switches to opt in instead of opt out? (that change is on the way I hear)

dotnet/sdk#19599

@tmat
tmat deleted the dev/tmat/implicitusings branch August 12, 2021 22:33
@Pilchie

Pilchie commented Aug 13, 2021

Copy link
Copy Markdown
Member

Tagging @DamianEdwards and @pranavkm

@dougbu

dougbu commented Aug 16, 2021

Copy link
Copy Markdown
Contributor

What does it mean for y'all @dougbu when the implicit using switches to opt in instead of opt out? (that change is on the way I hear)

It means we need to flip some logic in dotnet/aspnetcore. I'm not sure if that's already happened. @wtgodbe

@pranavkm

pranavkm commented Aug 16, 2021

Copy link
Copy Markdown
Contributor

AspNetCore is on a newer SDK that no longer uses this switch. This shouldn't affect AspNetCore any more.

@RussKie

RussKie commented Aug 18, 2021

Copy link
Copy Markdown
Contributor

Is this getting undone?

@markwilkie

Copy link
Copy Markdown
Contributor

Poking at this to see what next steps (if any) should be taken given the defaults change.

@RussKie

RussKie commented Sep 5, 2021

Copy link
Copy Markdown
Contributor

Repo owners must remove the original flag, if it was set in their repos explicitly. Other than that I can't think of anything else.
/cc: @DamianEdwards

@markwilkie

Copy link
Copy Markdown
Contributor

Thanks @RussKie - @tmat, should this be reverted then in Arcade?

@tmat

tmat commented Sep 15, 2021

Copy link
Copy Markdown
Member Author

Yeah, we should revert this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants