Skip to content

Update roslyn to 5.12.0-1.26452.1 #9725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoeRobich merged 6 commits into from
Sep 3, 2026
+13 −7
Merged

Update roslyn to 5.12.0-1.26452.1 #9725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2230e6f
Update Roslyn to 5.12.0-1.26452.1
dibarbet Sep 2, 2026
d5420ac
Update changelog with PR number
dibarbet Sep 2, 2026
5058f11
Apply batched suggestions from code review
dibarbet Sep 2, 2026
c53939d
Apply suggestion from @JoeRobich
dibarbet Sep 2, 2026
8a6c5c3
Fix Razor URI comparisons on Windows
JoeRobich Sep 3, 2026
2de1ed2
Use path assertion helper in Razor tests
JoeRobich Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,13 @@
- Diagnostics related feature requests and improvements [#5951](https://github.com/dotnet/vscode-csharp/issues/5951)
- Debug from .csproj and .sln [#5876](https://github.com/dotnet/vscode-csharp/issues/5876)

# 2.150.x
# 2.151.x
* Update Roslyn to 5.12.0-1.26452.1 (PR: [#9725](https://github.com/dotnet/vscode-csharp/pull/9725))
* Ignore spurious TypeScript diagnostics caused by Razor code (PR: [#85129](https://github.com/dotnet/roslyn/pull/85129))
* Clamp LSP position character to the line end (PR: [#85125](https://github.com/dotnet/roslyn/pull/85125))
* Fix IDE0002 for static abstract and virtual interface member access (PR: [#85037](https://github.com/dotnet/roslyn/pull/85037))
* Don't reload the entire project if only a cs file changes (PR: [#85091](https://github.com/dotnet/roslyn/pull/85091))
* Prevent Introduce Constant crash in top-level lambdas (PR: [#85071](https://github.com/dotnet/roslyn/pull/85071))
* Update Roslyn to 5.12.0-1.26428.1 (PR: [#9712](https://github.com/dotnet/vscode-csharp/pull/9712))
Comment on lines +12 to 13
* Fix extra newline after primary constructor parameter (PR: [#85030](https://github.com/dotnet/roslyn/pull/85030))
* Read unopened LSP files from disk without persisting them (PR: [#85061](https://github.com/dotnet/roslyn/pull/85061))
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"workspace"
],
"defaults": {
"roslyn": "5.12.0-1.26428.1",
"roslyn": "5.12.0-1.26452.1",
"omniSharp": "1.39.14",
"razorOmnisharp": "7.0.0-preview.23363.1",
"xamlTools": "18.10.12014.341",
Expand Down
10 changes: 5 additions & 5 deletions test/razor/razorIntegrationTests/reference.integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ describe(`Razor References ${testAssetWorkspace.description}`, function () {
expect(locations.length).toBe(1);
const definitionLocation = locations[0];

expect(definitionLocation.uri.path).toBe(vscode.window.activeTextEditor!.document.uri.path);
integrationHelpers.expectPath(vscode.window.activeTextEditor!.document.uri, definitionLocation.uri);
expect(definitionLocation.range.start.line).toBe(11);
expect(definitionLocation.range.start.character).toBe(16);
expect(definitionLocation.range.end.line).toBe(11);
Expand Down Expand Up @@ -74,21 +74,21 @@ describe(`Razor References ${testAssetWorkspace.description}`, function () {
expect(locations.length).toBe(3);

let definitionLocation = locations[0];
expect(definitionLocation.uri.path).toBe(vscode.window.activeTextEditor!.document.uri.path);
integrationHelpers.expectPath(vscode.window.activeTextEditor!.document.uri, definitionLocation.uri);
expect(definitionLocation.range.start.line).toBe(6);
expect(definitionLocation.range.start.character).toBe(33);
expect(definitionLocation.range.end.line).toBe(6);
expect(definitionLocation.range.end.character).toBe(45);

definitionLocation = locations[1];
expect(definitionLocation.uri.path).toBe(vscode.window.activeTextEditor!.document.uri.path);
integrationHelpers.expectPath(vscode.window.activeTextEditor!.document.uri, definitionLocation.uri);
expect(definitionLocation.range.start.line).toBe(11);
expect(definitionLocation.range.start.character).toBe(16);
expect(definitionLocation.range.end.line).toBe(11);
expect(definitionLocation.range.end.character).toBe(28);

definitionLocation = locations[2];
expect(definitionLocation.uri.path).toBe(vscode.window.activeTextEditor!.document.uri.path);
integrationHelpers.expectPath(vscode.window.activeTextEditor!.document.uri, definitionLocation.uri);
expect(definitionLocation.range.start.line).toBe(15);
expect(definitionLocation.range.start.character).toBe(8);
expect(definitionLocation.range.end.line).toBe(15);
Expand Down Expand Up @@ -117,7 +117,7 @@ describe(`Razor References ${testAssetWorkspace.description}`, function () {
expect(locations.length).toBe(1);
const definitionLocation = locations[0];

expect(definitionLocation.uri.path).toBe(vscode.window.activeTextEditor!.document.uri.path);
integrationHelpers.expectPath(vscode.window.activeTextEditor!.document.uri, definitionLocation.uri);
expect(definitionLocation.range.start.line).toBe(23);
expect(definitionLocation.range.start.character).toBe(10);
expect(definitionLocation.range.end.line).toBe(23);
Expand Down
Loading