Update roslyn to 5.12.0-1.26452.1 by dibarbet · Pull Request #9725 · dotnet/vscode-csharp

dibarbet · 2026-09-02T17:12:09Z

Official Roslyn build: 20260902.1 (build 3064069)

View Complete Diff of Changes

Ignore spurious TypeScript diagnostics caused by Razor code (PR: #85129)
Small PR follow-ups (PR: #85122)
Clamp LSP position character to the line end (PR: #85125)
FBA: add reproducer for transitive edit issue (PR: #85113)
Fix dotnet restore command syntax (PR: #85111)
Migrate CopyRefAssembly to multithreaded execution model (PR: #84420)
Unsafe evolution: add remaining public APIs (PR: #84860)
Fix local error type assert in nullable analysis (PR: #85103)
Migrate MapSourceRoots task to multithreaded mode (PR: #84421)
Migrate GenerateMSBuildEditorConfig task to multithreaded mode (PR: #84419)
Update Tasks.DataFlow bindingRedirect in MSBuildTasksTests (PR: #85110)
Various improvements to project loading and restore (PR: #85109)
Fix IDE0002 for static abstract and virtual interface member access (PR: #85037)
Embed F# external access resources under the name their accessor asks for (PR: #85095)
Record existing partial modifier parsing behavior (PR: #85108)
Consider the type of file change when we process file changes (PR: #85091)
Update SQLite Dependencies for nuget audit warnings (PR: #85015)
Support F# Document Outline via LSP textDocument/documentSymbol (PR: #85087)
Shut down compiler server before publishing rebuild logs (PR: #85039)
Refactor the LanguageServerProjectLoader (PR: #84982)
Send $/progress notifications with named arguments (PR: #85076)
Add asynchronous LSP request context accessors (PR: #84975)
[main] Update following VS snap (PR: #85084)
Remove known-issues memory docs and rebase guidance on issue-linked local documentation (PR: #85072)
Prevent Introduce Constant crash in top-level lambdas (PR: #85071)
Enable function resolution for SymbolOnly processes (PR: #85033)
Use VSEng-MicroBuildVSStable pool (PR: #85079)
Parse misplaced 'ref' modifier on type declarations (PR: #84935)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot review overview

🟡 Changes recommended

The new CHANGELOG entry includes at least one vague/implementation-focused bullet that should be omitted or clarified to match the repository’s Roslyn changelog filtering guidance.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Lite
Findings: 1

New issues introduced by this change (1)

Severity	Finding
	`CHANGELOG.md` — The new Roslyn changelog entry includes a few sub-bullets that are either vague ("Various…

What changed in this PR

Updates the VS Code C# extension’s bundled Roslyn language server version to a newer official build, and records the update in the extension changelog.

Changes:

Bump defaults.roslyn in package.json to 5.12.0-1.26452.1.
Add a new Roslyn update entry under # 2.150.x in CHANGELOG.md with selected user-facing highlights.

File	Description
package.json	Updates the default Roslyn language server version consumed by the extension.
CHANGELOG.md	Adds a new changelog entry describing the Roslyn version update and notable downstream PRs.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Co-authored-by: David Barbet <dibarbet@gmail.com>

Co-authored-by: Joey Robichaud <jorobich@microsoft.com>

Copilot

Copilot review overview

🟡 Changes recommended

The changelog update removes the 2.150.x heading, which misgroups prior entries and drops the historical release section structure.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Lite
Findings: 1

New issues introduced by this change (1)

Severity	Finding
	`CHANGELOG.md` — The CHANGELOG no longer has a `# 2.150.x` section (it was renamed to `# 2.151.x` in this hunk),…

Issues resolved since last review (1)

Severity	Finding
	`CHANGELOG.md` — The new Roslyn changelog entry includes a few sub-bullets that are either vague ("Various… View resolved comment

+  * Prevent Introduce Constant crash in top-level lambdas (PR: [#85071](https://github.com/dotnet/roslyn/pull/85071))
 * Update Roslyn to 5.12.0-1.26428.1 (PR: [#9712](https://github.com/dotnet/vscode-csharp/pull/9712))


Compare canonical URI strings so equivalent Windows drive-letter casing does not fail the reference integration tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2bc15778-e8b2-4b0b-9868-dfd45e11b2e1

Copilot

Copilot review overview

🟡 Changes recommended

The updated Razor integration tests compare URIs using toString() in a way that is likely to be overly strict and platform-sensitive, risking test failures.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Lite
Findings: 1 · 1

New issues introduced by this change (1)

Severity	Finding
	`test/razor/razorIntegrationTests/reference.integration.test.ts` — Comparing URIs via `toString()` is likely to make this test OS/encoding-sensitive (e.g., Windows…

Pre-existing issues (1)

Severity	Finding
	`CHANGELOG.md` — The CHANGELOG no longer has a `# 2.150.x` section (it was renamed to `# 2.151.x` in this hunk),… View comment

Suppressed comments (5)

Previously missed (1) — in code that hasn't changed since the last review.

CHANGELOG.md:11

This changelog bullet is a bit ambiguous as written; using “.cs” makes it clearer that this refers to C# source files.

test/razor/razorIntegrationTests/reference.integration.test.ts:77

Comparing URIs via toString() is likely to make this test OS/encoding-sensitive (e.g., Windows drive-letter casing) and unnecessarily strict about scheme/authority. Use the existing integrationHelpers.expectPath(...) helper to keep comparisons consistent and cross-platform.

                expect(definitionLocation.uri.toString()).toBe(vscode.window.activeTextEditor!.document.uri.toString());

test/razor/razorIntegrationTests/reference.integration.test.ts:84

Comparing URIs via toString() is likely to make this test OS/encoding-sensitive (e.g., Windows drive-letter casing) and unnecessarily strict about scheme/authority. Use the existing integrationHelpers.expectPath(...) helper to keep comparisons consistent and cross-platform.

                expect(definitionLocation.uri.toString()).toBe(vscode.window.activeTextEditor!.document.uri.toString());

test/razor/razorIntegrationTests/reference.integration.test.ts:91

Comparing URIs via toString() is likely to make this test OS/encoding-sensitive (e.g., Windows drive-letter casing) and unnecessarily strict about scheme/authority. Use the existing integrationHelpers.expectPath(...) helper to keep comparisons consistent and cross-platform.

                expect(definitionLocation.uri.toString()).toBe(vscode.window.activeTextEditor!.document.uri.toString());

test/razor/razorIntegrationTests/reference.integration.test.ts:120

Comparing URIs via toString() is likely to make this test OS/encoding-sensitive (e.g., Windows drive-letter casing) and unnecessarily strict about scheme/authority. Use the existing integrationHelpers.expectPath(...) helper (used elsewhere in this file) to keep comparisons consistent and cross-platform.

                expect(definitionLocation.uri.toString()).toBe(vscode.window.activeTextEditor!.document.uri.toString());

Use the shared platform-aware path comparison helper for Razor navigation results. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2bc15778-e8b2-4b0b-9868-dfd45e11b2e1

Copilot

Copilot review overview

🟢 Approval recommended

The changes are straightforward (version bump + changelog + test robustness tweak) with only a minor changelog wording nit noted.

Review tier: Lite
Findings: 1

Pre-existing issues (1)

Severity	Finding
	`CHANGELOG.md` — The CHANGELOG no longer has a `# 2.150.x` section (it was renamed to `# 2.151.x` in this hunk),… View comment

Issues resolved since last review (1)

Severity	Finding
	`test/razor/razorIntegrationTests/reference.integration.test.ts` — Comparing URIs via `toString()` is likely to make this test OS/encoding-sensitive (e.g., Windows… View resolved comment

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

CHANGELOG.md:11

Changelog entry says “cs file” which is inconsistent with other entries in this file (typically “.cs file”) and is slightly ambiguous for readers.

Update Roslyn to 5.12.0-1.26452.1

2230e6f

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI lite review requested due to automatic review settings September 2, 2026 17:12

dibarbet requested a review from a team as a code owner September 2, 2026 17:12

Update changelog with PR number

d5420ac

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot started reviewing on behalf of dibarbet September 2, 2026 17:12 View session

Copilot AI reviewed Sep 2, 2026

View reviewed changes

Comment thread CHANGELOG.md Outdated

JoeRobich approved these changes Sep 2, 2026

View reviewed changes

JoeRobich reviewed Sep 2, 2026

View reviewed changes

Comment thread CHANGELOG.md Outdated

dibarbet commented Sep 2, 2026

View reviewed changes

Comment thread CHANGELOG.md Outdated

Comment thread CHANGELOG.md Outdated

Comment thread CHANGELOG.md Outdated

Apply batched suggestions from code review

5058f11

Co-authored-by: David Barbet <dibarbet@gmail.com>

Copilot AI review requested due to automatic review settings September 2, 2026 17:43

JoeRobich approved these changes Sep 2, 2026

View reviewed changes

Copilot started reviewing on behalf of dibarbet September 2, 2026 17:44 View session

Apply suggestion from @JoeRobich

c53939d

Co-authored-by: Joey Robichaud <jorobich@microsoft.com>

JoeRobich approved these changes Sep 2, 2026

View reviewed changes

Copilot AI reviewed Sep 2, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings September 3, 2026 17:20

Copilot started reviewing on behalf of JoeRobich September 3, 2026 17:21 View session

Copilot AI reviewed Sep 3, 2026

View reviewed changes

Comment thread test/razor/razorIntegrationTests/reference.integration.test.ts Outdated

Use path assertion helper in Razor tests

2de1ed2

Use the shared platform-aware path comparison helper for Razor navigation results. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2bc15778-e8b2-4b0b-9868-dfd45e11b2e1

Copilot AI review requested due to automatic review settings September 3, 2026 17:34

Copilot started reviewing on behalf of JoeRobich September 3, 2026 17:35 View session

Copilot AI reviewed Sep 3, 2026

View reviewed changes

JoeRobich approved these changes Sep 3, 2026

View reviewed changes

akhera99 approved these changes Sep 3, 2026

View reviewed changes

JoeRobich enabled auto-merge (squash) September 3, 2026 18:16

JoeRobich merged commit 4af193b into main Sep 3, 2026
39 checks passed

JoeRobich deleted the dibarbet-update-roslyn-5-12-0-1-26452-1 branch September 3, 2026 19:19

Navigation Menu

Uh oh!

Update roslyn to 5.12.0-1.26452.1 - #9725

Update roslyn to 5.12.0-1.26452.1#9725
JoeRobich merged 6 commits into
mainfrom
dibarbet-update-roslyn-5-12-0-1-26452-1

dibarbet commented Sep 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		* Prevent Introduce Constant crash in top-level lambdas (PR: [#85071](https://github.com/dotnet/roslyn/pull/85071))
		* Update Roslyn to 5.12.0-1.26428.1 (PR: [#9712](https://github.com/dotnet/vscode-csharp/pull/9712))

Uh oh!

Conversation

dibarbet commented Sep 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants