Clarify volume mount wording in persist DB tutorial#25405
Open
devendrakushwah80 wants to merge 1 commit into
Open
Clarify volume mount wording in persist DB tutorial#25405devendrakushwah80 wants to merge 1 commit into
devendrakushwah80 wants to merge 1 commit into
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
the
area/get-started
Contributor
|
/review |
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The wording change is technically accurate and clear. The previous text ("Give the volume a name") was misleading because the volume todo-db is already created in step 1. The new text ("Use the volume named todo-db") correctly reflects that the existing volume is being referenced as the mount source. No issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clarifies the wording in the "Persist the DB" workshop tutorial.
The volume is already created and named (
todo-db) in step 1 usingdocker volume create. The previous wording in step 3 suggested that the volume was being named there, while the command actually uses the existing volume as the mount source.This change updates the wording to make the workflow clearer and more technically accurate.
Related issues or tickets
Fixes #25404
Reviews