Documentation error in Part 4: Persist the DB

[a-staab]

Is this a docs issue?

• My issue is about the documentation content or website

Type of issue

Information is incorrect

Description

https://docs.docker.com/get-started/workshop/05_persisting_data/

See image. The mistake is in step 3. Specifically, it says "Give the volume a name..." By this time, however, the volume already has a name. The name is created in step 1, which is probably where this phrase should actually appear. In step 3 we are only passing the already defined name as an argument to identify the source for mounting the volume.

Location

https://docs.docker.com/get-started/workshop/05_persisting_data/

Suggestion

I'd originally thought the obvious remedy was to move the part about giving the volume a name to step 1. However, on further consideration, I think maybe the author meant to say in step 3, "Give the container a name." If so, the actual command needs changed as well though to pass in a value to --name. So possibly:

docker run -dp 127.0.0.1:3000:3000 --name my-todo-app --mount type=volume,src=todo-db,target=/etc/todos getting-started

(And remember to update the Git Bash version below as well.)

I'd make those changes and add "Give the volume a name" to step 1.

[devendrakushwah80]

I'd like to investigate and work on this issue.

The wording in step 3 appears to describe naming the volume, while the volume is already created and named in step 1. I'll review the tutorial flow and submit a fix if appropriate.