Skip to content

fix: fixes pretty printing the concatenation of an empty list of documents - #669

Merged
christoph-dfinity merged 2 commits into
masterfrom
christoph/concat-empty
Aug 4, 2025
Merged

fix: fixes pretty printing the concatenation of an empty list of documents#669
christoph-dfinity merged 2 commits into
masterfrom
christoph/concat-empty

Conversation

@christoph-dfinity

@christoph-dfinity christoph-dfinity commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

Fixes #667

Alternative to #668, that doesn't constitute a breaking change

@christoph-dfinity
christoph-dfinity requested a review from a team as a code owner August 4, 2025 10:12
@github-actions

github-actions Bot commented Aug 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Name Max Mem (Kb) Encode Decode
blob 4_224 4_206_559 2_121_049
btreemap 75_456 4_261_360_420 ($\textcolor{green}{-0.00\%}$) 15_191_359_356
nns 128 1_966_452 ($\textcolor{red}{0.00\%}$) 5_458_839 ($\textcolor{green}{-0.14\%}$)
nns_list_proposal 1_088 6_811_021 ($\textcolor{green}{-0.45\%}$) 66_998_641 ($\textcolor{red}{0.00\%}$)
option_list 128 7_481_787 ($\textcolor{red}{0.09\%}$) 25_779_081 ($\textcolor{red}{0.33\%}$)
text 6_336 4_203_506 7_877_217
variant_list 128 7_536_918 ($\textcolor{red}{0.08\%}$) 23_953_572 ($\textcolor{green}{-0.35\%}$)
vec_int16 16_704 123_693_002 1_019_238_917
  • Parser cost: 15_215_551 ($\textcolor{green}{-0.01\%}$)
  • Extra args: 3_165_359 ($\textcolor{red}{0.00\%}$)
Click to see raw report 
---------------------------------------------------

Benchmark: blob
  total:
    instructions: 6.33 M (no change)
    heap_increase: 66 pages (no change)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    calls: 1 (no change)
    instructions: 4.21 M (no change)
    heap_increase: 66 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    calls: 1 (no change)
    instructions: 2.12 M (no change)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: text
  total:
    instructions: 12.08 M (no change)
    heap_increase: 99 pages (no change)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    calls: 1 (no change)
    instructions: 4.20 M (no change)
    heap_increase: 66 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    calls: 1 (no change)
    instructions: 7.88 M (no change)
    heap_increase: 33 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: vec_int16
  total:
    instructions: 1.14 B (no change)
    heap_increase: 261 pages (no change)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    calls: 1 (no change)
    instructions: 123.69 M (no change)
    heap_increase: 261 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    calls: 1 (no change)
    instructions: 1.02 B (no change)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: btreemap
  total:
    instructions: 19.45 B (-0.00%) (change within noise threshold)
    heap_increase: 1179 pages (no change)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    calls: 1 (no change)
    instructions: 4.26 B (-0.00%) (change within noise threshold)
    heap_increase: 159 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    calls: 1 (no change)
    instructions: 15.19 B (no change)
    heap_increase: 1020 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: option_list
  total:
    instructions: 33.26 M (0.27%) (change within noise threshold)
    heap_increase: 2 pages (no change)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    calls: 1 (no change)
    instructions: 7.48 M (0.09%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    calls: 1 (no change)
    instructions: 25.78 M (0.33%) (change within noise threshold)
    heap_increase: 2 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: variant_list
  total:
    instructions: 31.49 M (-0.25%) (change within noise threshold)
    heap_increase: 2 pages (no change)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    calls: 1 (no change)
    instructions: 7.54 M (0.08%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    calls: 1 (no change)
    instructions: 23.95 M (-0.35%) (change within noise threshold)
    heap_increase: 2 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: nns
  total:
    instructions: 23.48 M (-0.04%) (change within noise threshold)
    heap_increase: 2 pages (no change)
    stable_memory_increase: 0 pages (no change)

  0. Parsing (scope):
    calls: 1 (no change)
    instructions: 15.22 M (-0.01%) (change within noise threshold)
    heap_increase: 2 pages (no change)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    calls: 1 (no change)
    instructions: 1.97 M (0.00%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    calls: 1 (no change)
    instructions: 5.46 M (-0.14%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: nns_list_proposal
  total:
    instructions: 73.81 M (-0.04%) (change within noise threshold)
    heap_increase: 17 pages (no change)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    calls: 1 (no change)
    instructions: 6.81 M (-0.45%) (change within noise threshold)
    heap_increase: 3 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    calls: 1 (no change)
    instructions: 67.00 M (0.00%) (change within noise threshold)
    heap_increase: 14 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: extra_args
  total:
    instructions: 3.17 M (0.00%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Summary:
  instructions:
    status:   No significant changes 👍
    counts:   [total 9 | regressed 0 | improved 0 | new 0 | unchanged 9]
    change:   [max +90.39K | p75 0 | median 0 | p25 -8.66K | min -78.18K]
    change %: [max +0.27% | p75 0.00% | median 0.00% | p25 -0.04% | min -0.25%]

  heap_increase:
    status:   No significant changes 👍
    counts:   [total 9 | regressed 0 | improved 0 | new 0 | unchanged 9]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes 👍
    counts:   [total 9 | regressed 0 | improved 0 | new 0 | unchanged 9]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------
Successfully persisted results to canbench_results.yml

ilbertt
ilbertt approved these changes Aug 4, 2025
View reviewed changes

@ilbertt ilbertt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for the fix.

Regarding #668, we can merge it into the next branch, where we are already collecting the breaking changes for v0.11

Comment thread CHANGELOG.md Outdated
@christoph-dfinity @ilbertt
Update CHANGELOG.md
82d4504 
Co-authored-by: Luca Bertelli <luca.bertelli@dfinity.org>
@christoph-dfinity
christoph-dfinity merged commit 611fe5f into master Aug 4, 2025
11 checks passed
@christoph-dfinity
christoph-dfinity deleted the christoph/concat-empty branch August 4, 2025 11:24
lastmjs pushed a commit to demergent-labs/candid that referenced this pull request Aug 7, 2025
@christoph-dfinity @lastmjs
fix: fixes pretty printing the concatenation of an empty list of docu…
45f3826 
…ments (dfinity#669)

Fixes dfinity#667

Alternative to dfinity#668, that doesn't constitute a breaking change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@ilbertt ilbertt ilbertt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error: Broken function concat

2 participants

@christoph-dfinity @ilbertt