refactor: pretty printing combinator for lists/tuples - #668
Merged
Conversation
Click to see raw report |
Gets rid of the dodgy is_empty function that traversed documents to tell if they were empty
christoph-dfinity
force-pushed
the
christoph/sep-enclose-combinator
branch
from
August 4, 2025 09:05
0101732 to
c32d56c
Compare
lastmjs
pushed a commit
to demergent-labs/candid
that referenced
this pull request
Aug 7, 2025
…ments (dfinity#669) Fixes dfinity#667 Alternative to dfinity#668, that doesn't constitute a breaking change
christoph-dfinity
added a commit
that referenced
this pull request
Aug 11, 2025
Looks like a recent bump of the Rust version on CI introduced new Clippy lints that make CI fail on #668 This PR fixes those lint errors on the `next` branch.
ilbertt
suggested changes
Aug 11, 2025
ilbertt
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gets rid of the dodgy
is_emptyfunction that performed full traversals of documents to tell if they were empty.Fixes #667