[3.3.8] Bump golang.org/x modules and align Go version to 1.25.14 - #8761
Merged
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Large Go toolchain and core golang.org/x/{crypto,net} upgrades can have broad runtime/regression impact and should be validated by full CI before approval.
Pull request overview
Updates the Sync Gateway 3.3.8 release branch to build/test with Go 1.25.14 and bumps golang.org/x/* dependencies to the latest versions compatible with Go 1.25, keeping CI and build tooling aligned with the module requirements.
Changes:
- Bump
golang.org/x/crypto,x/net,x/oauth2,x/sys,x/text, andx/timedependency versions. - Update the module
goversion directive to 1.25.14. - Align GitHub Actions workflows and Jenkins pipeline to use Go 1.25.14.
File summaries
| File | Description |
|---|---|
go.mod |
Updates Go version directive and bumps golang.org/x/* module requirements. |
go.sum |
Refreshes module checksums to match the upgraded golang.org/x/* dependencies. |
.github/workflows/ci.yml |
Pins CI jobs to Go 1.25.14 to match the updated module/toolchain baseline. |
.github/workflows/service.yml |
Pins service install workflow build to Go 1.25.14. |
Jenkinsfile |
Updates Jenkins Go tool version to 1.25.14 for pipeline builds. |
Review details
- Files reviewed: 4/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
golangci-lint v2.0.2 is built with go1.24 and refuses to load a config targeting a newer language version. v2.8.0 matches 4.0.8. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
torcolvin
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest
golang.org/x/*releases that Go 1.25 will take:x/cryptostops at v0.55.0 - v0.56.0 needsgo1.26.0.x/expleft alone, it's pseudo-versioned with no tagged releases.Go version bump comes with it rather than being optional -
x/cryptov0.49.0+ andx/netv0.51.0+ both declarego1.25.0, sogo getwon't apply them under ago 1.24.3directive.manifest/product-config.jsonalready has 3.3.8 building on 1.25.14 whilstgo.modwas on 1.24.3,ci.yml/Jenkinsfileon 1.24.4 andservice.ymlas far back as 1.23.3 - all four now say 1.25.14.Lint needed bumping with it - golangci-lint v2.0.2 is built with
go1.24and won't even load a config targeting a newer language version (can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.14)). Moved to v2.8.0 to match 4.0.8, which turns up one pre-existingmisspellhit inbase/dcp_dest.gothat v2.0.2 never caught - 4.0.8, 4.1.2 andmainall spell itimplementedalready, so that's 3.3.8 catching up rather than a new change.go build,go vet,yamllintand the unit suite all pass locally withcb_sg_enterprise,cb_sg_devmode.🤖 Generated with Claude Code