Convert variable type to int if it was an integer fixes #5688 - #5691
Convert variable type to int if it was an integer fixes #5688#5691rfikree92 wants to merge 2 commits into
Conversation
MGatner
left a comment
There was a problem hiding this comment.
Inline comment. Also we would need a test to cover this - should be a straightforward adjustment of current tests.
|
@rfikree92 Thank you for sending this PR. Some GitHub Action checks failed. And fix and add unit tests. |
|
I think the following test cases are needed: https://www.php.net/manual/en/function.is-numeric.php#refsect1-function.is-numeric-examples |
|
#5779 was merged. |
Fixes #5688
Description
convert any variable that is a number to int type, so errors like #5688 doesn't happen.
Checklist: