Skip to content

fix: Ajax request makes the session expire when app.sessionExpiration is set to 0 - #5690

Closed
kenjis wants to merge 2 commits into
codeigniter4:developfrom
kenjis:fix-sessionExpiration
Closed

fix: Ajax request makes the session expire when app.sessionExpiration is set to 0#5690
kenjis wants to merge 2 commits into
codeigniter4:developfrom
kenjis:fix-sessionExpiration

Conversation

@kenjis

@kenjis kenjis commented Feb 13, 2022

Copy link
Copy Markdown
Member

Description
Fixes #5688

  • When setting in .env, all values are string.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

When setting in .env, all values are string.
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Feb 13, 2022
@kenjis
kenjis marked this pull request as draft February 13, 2022 10:16
@kenjis
kenjis marked this pull request as ready for review February 13, 2022 10:23
@kenjis

kenjis commented Feb 13, 2022

Copy link
Copy Markdown
Member Author

Should we fix DotEnv to convert variable types?
No, we use not only DotEnv but also environment variables which are all strings.

@kenjis

kenjis commented Feb 13, 2022

Copy link
Copy Markdown
Member Author

Should we fix BaseConfig::initEnvValue() to convert variable types?
Ref #5691

@kenjis

kenjis commented Apr 12, 2022

Copy link
Copy Markdown
Member Author

#5779 was merged.

@kenjis kenjis closed this Apr 12, 2022
@kenjis
kenjis deleted the fix-sessionExpiration branch April 12, 2022 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Ajax request makes the session expire when app.sessionExpiration is set to 0

1 participant