Frontend: Remove Electron references from the interface - #2841
Conversation
Automated PR Review (Claude)0. SummaryVerdict: MINOR SUGGESTIONS Minor items to address: 1.1 This PR replaces user-facing references to "Electron", "desktop version", "standalone version", etc. with the branded edition names "Cockpit Standalone" and "Cockpit Lite" across 15 files. Internal code (runtime guards, identifiers, file names) correctly retains the Electron name. The change is well-scoped, consistent, and addresses issue #2627. 1. Correctness & Implementation Bugs1.1 (
These should say "Cockpit Lite" for consistency with the stated naming convention. The mix of "browser version" and "Cockpit Lite" across the app would be confusing to users. 2. AGENTS.md Adherence — ✅3. Security — ✅4. Performance — ✅5. UI / UX — ✅6. Code Quality & Style — ✅7. Commit Hygiene — ✅8. Tests — ✅9. Documentation — ✅10. Nitpicks / Optional10.1 ( Generated by Claude. This is advisory; a human reviewer must still approve. |
Users are not expected to know Electron is the desktop runtime, so every snackbar, tooltip, dialog, alert and data-lake entry now names the desktop edition "Cockpit Standalone" and the web edition "Cockpit Lite" instead of flip-flopping between "Electron", "Desktop" and "standalone". Internal identifiers, guards and comments keep the Electron name.
c098e76 to
f62dcf2
Compare
|
Done:
Not addressed:
|
|
/review |
Automated PR Re-review 2 (Claude)Comparing Previous findings status
Discussion since last review@ArturoManzoli confirmed that 1.1 was fixed ("renamed the remaining user-facing 'browser version' / 'Browser Version' strings to 'Cockpit Lite'"). For 10.1, the author intentionally kept "(Standalone)" because the variable names already start with "Cockpit" (e.g. "Cockpit Main Memory (Standalone)"), so the full form would double the word. That reasoning is sound — marking as no longer applicable. New findings0. SummaryVerdict: READY TO MERGE This PR replaces user-facing references to "Electron", "desktop version", "browser version", etc. with the branded edition names "Cockpit Standalone" and "Cockpit Lite" across 15 files. The previous finding (inconsistent "browser version" strings) has been fully addressed. The change is well-scoped, consistent, and correctly closes #2627. 1. Correctness & Implementation Bugs — ✅2. AGENTS.md Adherence — ✅3. Security — ✅4. Performance — ✅5. UI / UX — ✅6. Code Quality & Style — ✅7. Commit Hygiene — ✅8. Tests — ✅9. Documentation — ✅10. Nitpicks / Optional — ✅Generated by Claude. This is advisory; a human reviewer must still approve. |
|
Ready to go. |
|
Everything looks good. |
rafaellehmkuhl
left a comment
There was a problem hiding this comment.
As discussed internally, I like the Standalone name and vote for using it, but we should wait for SMS's (with which @ES-Alexander will be bringing the topic to) take on it.
Closes #2627