Skip to content

Frontend: Remove Electron references from the interface - #2841

Merged
ArturoManzoli merged 1 commit into
bluerobotics:masterfrom
ArturoManzoli:2627-remove-electron-references-interface
Jul 16, 2026
Merged

Frontend: Remove Electron references from the interface#2841
ArturoManzoli merged 1 commit into
bluerobotics:masterfrom
ArturoManzoli:2627-remove-electron-references-interface

Conversation

@ArturoManzoli

Copy link
Copy Markdown
Contributor
  • User-facing snackbars, tooltips, dialogs, alerts and data-lake variables no longer mention "Electron", an implementation detail users are not expected to know.
  • The desktop edition is now consistently called "Cockpit Standalone" and the web edition "Cockpit Lite", replacing the previous mix of "Electron", "Desktop" and "standalone".
  • "Standalone" is capitalized because it names an edition, exactly like "Lite" in "Cockpit Lite": both are branded product editions (proper nouns), not plain adjectives describing a build.
  • Internal code (runtime guards, identifiers, comments) keeps the Electron name.

Closes #2627

@github-actions

Copy link
Copy Markdown

Automated PR Review (Claude)

0. Summary

Verdict: MINOR SUGGESTIONS

Minor items to address: 1.1

This PR replaces user-facing references to "Electron", "desktop version", "standalone version", etc. with the branded edition names "Cockpit Standalone" and "Cockpit Lite" across 15 files. Internal code (runtime guards, identifiers, file names) correctly retains the Electron name. The change is well-scoped, consistent, and addresses issue #2627.

1. Correctness & Implementation Bugs

1.1 (minor) — Inconsistent "browser version" phrasing left behind. Several user-facing strings were updated to use "Cockpit Standalone" for the desktop edition, but the web edition is not always updated to "Cockpit Lite". The PR body states the web edition should be called "Cockpit Lite", and one file (HttpRequestActionConfig.vue) does use that term, but other files still say "browser version":

  • src/components/VideoLibraryModal.vue (diff line ~11): "The browser version can only record the video chunks."
  • src/views/ConfigurationVideoView.vue (diff line ~337): "Video processing is not available in the browser version."
  • src/views/ConfigurationSourcesView.vue (diff line ~312): heading still reads "Browser Version".

These should say "Cockpit Lite" for consistency with the stated naming convention. The mix of "browser version" and "Cockpit Lite" across the app would be confusing to users.

2. AGENTS.md Adherence — ✅

3. Security — ✅

4. Performance — ✅

5. UI / UX — ✅

6. Code Quality & Style — ✅

7. Commit Hygiene — ✅

8. Tests — ✅

9. Documentation — ✅

10. Nitpicks / Optional

10.1 (nit) — In src/stores/omniscientLogger.ts, the data-lake variable descriptions now say "Only available in Cockpit Standalone." while the parenthetical in the name field says just "(Standalone)". Consider using the full branded name "(Cockpit Standalone)" in the name field as well, since these names are user-visible in the data-lake UI. This is already what the description fields do.

Generated by Claude. This is advisory; a human reviewer must still approve.

Users are not expected to know Electron is the desktop runtime, so every
snackbar, tooltip, dialog, alert and data-lake entry now names the desktop
edition "Cockpit Standalone" and the web edition "Cockpit Lite" instead of
flip-flopping between "Electron", "Desktop" and "standalone". Internal
identifiers, guards and comments keep the Electron name.
@ArturoManzoli
ArturoManzoli force-pushed the 2627-remove-electron-references-interface branch from c098e76 to f62dcf2 Compare July 15, 2026 16:33
@ArturoManzoli

Copy link
Copy Markdown
Contributor Author

Done:

  • (1.1) renamed the remaining user-facing "browser version" / "Browser Version" strings to "Cockpit Lite" (7 spots across the video config, sources config and video library) so the web edition is named consistently everywhere.

Not addressed:

  • (10.1) kept "(Standalone)" in the data-lake variable name fields rather than "(Cockpit Standalone)" — the names already start with "Cockpit" (e.g. "Cockpit Main Memory (Standalone)"), so the full form would double the word.

@ArturoManzoli

Copy link
Copy Markdown
Contributor Author

/review

@github-actions

Copy link
Copy Markdown

Automated PR Re-review 2 (Claude)

Comparing c098e76d37d73f824b455f9e45a3ba4df625d486f62dcf245819e14f7f11e71acd801610dfaf1f06

Previous findings status

# Finding Severity Status
1.1 Inconsistent "browser version" phrasing left behind in VideoLibraryModal, ConfigurationVideoView, ConfigurationSourcesView minor ✅ Addressed
10.1 Data-lake variable name fields use "(Standalone)" instead of "(Cockpit Standalone)" nit ⚪ No longer applicable

Discussion since last review

@ArturoManzoli confirmed that 1.1 was fixed ("renamed the remaining user-facing 'browser version' / 'Browser Version' strings to 'Cockpit Lite'"). For 10.1, the author intentionally kept "(Standalone)" because the variable names already start with "Cockpit" (e.g. "Cockpit Main Memory (Standalone)"), so the full form would double the word. That reasoning is sound — marking as no longer applicable.

New findings

0. Summary

Verdict: READY TO MERGE

This PR replaces user-facing references to "Electron", "desktop version", "browser version", etc. with the branded edition names "Cockpit Standalone" and "Cockpit Lite" across 15 files. The previous finding (inconsistent "browser version" strings) has been fully addressed. The change is well-scoped, consistent, and correctly closes #2627.

1. Correctness & Implementation Bugs — ✅

2. AGENTS.md Adherence — ✅

3. Security — ✅

4. Performance — ✅

5. UI / UX — ✅

6. Code Quality & Style — ✅

7. Commit Hygiene — ✅

8. Tests — ✅

9. Documentation — ✅

10. Nitpicks / Optional — ✅

Generated by Claude. This is advisory; a human reviewer must still approve.

@ArturoManzoli

Copy link
Copy Markdown
Contributor Author

Ready to go.

@rafaellehmkuhl

Copy link
Copy Markdown
Member

Everything looks good.
Will wait for @ES-Alexander take on that.

@rafaellehmkuhl rafaellehmkuhl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed internally, I like the Standalone name and vote for using it, but we should wait for SMS's (with which @ES-Alexander will be bringing the topic to) take on it.

@ArturoManzoli
ArturoManzoli merged commit 73cb6b9 into bluerobotics:master Jul 16, 2026
13 checks passed
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-needed Change needs to be documented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

frontend: remove references to Electron from the interface

3 participants