Skip to content

refactor(useExportType): dedup code - #10681

Merged
Conaclos merged 5 commits into
mainfrom
conaclos/useExportType-dedup-code
Jun 19, 2026
Merged

refactor(useExportType): dedup code#10681
Conaclos merged 5 commits into
mainfrom
conaclos/useExportType-dedup-code

Conversation

@Conaclos

@Conaclos Conaclos commented Jun 17, 2026

Copy link
Copy Markdown
Member

Summary

Follow-up of #10561 that deduplicates code.

I added a new utility function split_separated_list in biome_analyze that allows splitting a list into two lists based on a function.
This allowed me to reduce some duplications in useExportType and useImportType.

I solved the duplication I talked in a comment by adding a new node union AnyJsExportSpecifier and by removing useless diagnostic details (the detail reported that an export with a type keyword was a type).

Test Plan

Expecting a green CI.

Docs

No user-facing changes.

@changeset-bot

changeset-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 206c7fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-win32-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/wasm-web Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

✅ Organic activity

No automation signals detected in the analyzed events.

View full analysis →

This is an automated analysis by AgentScan

@github-actions github-actions Bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Jun 17, 2026
i Using export type allows compilers to safely drop exports of types without looking for their definition.

i Safe fix: Extract types into a new export.
i Safe fix: Separate types into a new export.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Separate instead of Extract is better because this matches the docs.

@Conaclos
Conaclos force-pushed the conaclos/useExportType-dedup-code branch from ecea055 to 38d256c Compare June 17, 2026 20:44
@Conaclos
Conaclos requested a review from ematipico June 17, 2026 20:45
@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c8ba3085-1bce-4b52-8150-60d68f6e6bac

📥 Commits

Reviewing files that changed from the base of the PR and between 38d256c and 206c7fc.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock and included by **
📒 Files selected for processing (6)
  • .changeset/thick-bugs-push.md
  • crates/biome_analyze/Cargo.toml
  • crates/biome_analyze/src/utils.rs
  • crates/biome_js_analyze/Cargo.toml
  • crates/biome_js_analyze/src/lint/style/use_export_type.rs
  • crates/biome_js_analyze/src/lint/style/use_import_type.rs
✅ Files skipped from review due to trivial changes (1)
  • .changeset/thick-bugs-push.md
🚧 Files skipped from review as they are similar to previous changes (2)
  • crates/biome_js_analyze/src/lint/style/use_import_type.rs
  • crates/biome_js_analyze/src/lint/style/use_export_type.rs

Walkthrough

A generic split_separated_list function is added to biome_analyze::utils to partition AstSeparatedList values into two detached lists via a caller-provided closure, preserving trailing separators on the correct side.

use_export_type is refactored to use a new public AnyJsExportSpecifier union type covering both named and named-from specifiers, with a with_type_token helper. The ExportTypeFix enum's *2 variants are removed; AddInlineTypeQualifiers and SeparateTypes now carry Vec<AnyJsExportSpecifier>. Split helpers and action branches are rewritten using split_separated_list.

use_import_type's manual specifier split loop is replaced with a split_separated_list call.

Possibly related PRs

  • biomejs/biome#10561: Directly overlaps with the use_export_type fix-state and named/named-from splitting refactor being continued here.
  • biomejs/biome#10569: Touches the same SeparateTypes/SeparateTypes2 variants and split helpers that this PR consolidates.
  • biomejs/biome#10530: Modifies use_import_type specifier classification logic that overlaps with this PR's split_separated_list adoption.

Suggested reviewers

  • ematipico
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarises the main objective—refactoring the useExportType rule to deduplicate code—which aligns with the changeset's core purpose.
Description check ✅ Passed The description clearly explains the refactoring's scope, including the new utility function, code deduplication across rules, node union addition, and diagnostic improvements.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch conaclos/useExportType-dedup-code

Comment @coderabbitai help to get the list of available commands and usage tips.

@codspeed-hq

codspeed-hq Bot commented Jun 17, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 247 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
db_17847247775464589309.json[uncached] 13.5 ms 14.4 ms -6.46%
uncached[simple_classes.txt] 219.3 µs 206.4 µs +6.27%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing conaclos/useExportType-dedup-code (206c7fc) with main (043fbb5)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (a0f197e) during the generation of this report, so 043fbb5 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@ematipico ematipico left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Split and use either. The rest are nits, but I think the loop I flagged needs to be changed

Comment thread crates/biome_analyze/src/utils.rs Outdated
Comment thread crates/biome_analyze/src/utils.rs Outdated
Comment thread crates/biome_analyze/src/utils.rs
Comment thread crates/biome_js_analyze/src/lint/style/use_export_type.rs
@Conaclos
Conaclos merged commit 888515b into main Jun 19, 2026
38 of 40 checks passed
@Conaclos
Conaclos deleted the conaclos/useExportType-dedup-code branch June 19, 2026 21:05
@github-actions github-actions Bot mentioned this pull request Jun 19, 2026
OIRNOIR pushed a commit to OIRNOIR/YouTube-Helper-Server that referenced this pull request Jun 30, 2026
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@biomejs/biome](https://biomejs.dev) ([source](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome)) | imports | patch | [`2.5.0` -> `2.5.1`](https://renovatebot.com/diffs/npm/@biomejs%2fbiome/2.5.0/2.5.1) |

---

### Release Notes

<details>
<summary>biomejs/biome (@&#8203;biomejs/biome)</summary>

### [`v2.5.1`](https://github.com/biomejs/biome/blob/HEAD/packages/@&#8203;biomejs/biome/CHANGELOG.md#251)

[Compare Source](https://github.com/biomejs/biome/compare/@biomejs/biome@2.5.0...@biomejs/biome@2.5.1)

##### Patch Changes

- [#&#8203;10722](biomejs/biome#10722) [`f8a303d`](biomejs/biome@f8a303d) Thanks [@&#8203;denbezrukov](https://github.com/denbezrukov)! - Fixed CSS formatter output for comments between import media queries.

  ```diff
  -@&#8203;import url("print.css") print,
  -/* comment */
  -screen;
  +@&#8203;import url("print.css") print, /* comment */ screen;
  ```

- [#&#8203;10738](biomejs/biome#10738) [`9fdc560`](biomejs/biome@9fdc560) Thanks [@&#8203;JamBalaya56562](https://github.com/JamBalaya56562)! - Fixed [#&#8203;9899](biomejs/biome#9899): the `json` and `json-pretty` reporters now escape backslashes in a diagnostic's `location.path`. Previously, paths containing backslashes (such as Windows-style paths) were emitted unescaped, producing invalid JSON.

  ```diff
  -    "path": "src\account\setup-passkey.tsx",
  +    "path": "src\\account\\setup-passkey.tsx",
  ```

- [#&#8203;10626](biomejs/biome#10626) [`5f837df`](biomejs/biome@5f837df) Thanks [@&#8203;tom-groves](https://github.com/tom-groves)! - Fixed [#&#8203;10625](biomejs/biome#10625): `biome migrate` no longer emits an invalid trailing comma when a renamed rule (such as `noConsoleLog` → `noConsole`) is the last member of its rule group. Previously this produced malformed output that aborted the migration of a strict-JSON `biome.json` with a parsing error.

- [#&#8203;10535](biomejs/biome#10535) [`c245f9d`](biomejs/biome@c245f9d) Thanks [@&#8203;Mokto](https://github.com/Mokto)! - Fixed a false positive in [`noUnusedVariables`](https://biomejs.dev/linter/rules/no-unused-variables/) for Svelte files where variables referenced inside `{@&#8203;html expr}` blocks were incorrectly reported as unused.

- [#&#8203;10668](biomejs/biome#10668) [`a0f197e`](biomejs/biome@a0f197e) Thanks [@&#8203;Netail](https://github.com/Netail)! - The `biome init` command has been updated to include a more up-to-date URL to [the first-party extensions page](https://biomejs.dev/editors/first-party-extensions/).

- [#&#8203;10667](biomejs/biome#10667) [`d8c3e87`](biomejs/biome@d8c3e87) Thanks [@&#8203;Netail](https://github.com/Netail)! - Fixed [#&#8203;10664](biomejs/biome#10664): [useErrorCause](https://biomejs.dev/linter/rules/use-error-cause/) now correctly detects a shorthand property.

- [#&#8203;10696](biomejs/biome#10696) [`ef2373f`](biomejs/biome@ef2373f) Thanks [@&#8203;ematipico](https://github.com/ematipico)! - Fixed [#&#8203;9566](biomejs/biome#9566). Improved how the Biome Language Server loads multiple configuration files inside a workspace.

- [#&#8203;10705](biomejs/biome#10705) [`4ccb410`](biomejs/biome@4ccb410) Thanks [@&#8203;ematipico](https://github.com/ematipico)! - Fixed [#&#8203;10652](biomejs/biome#10652). Biome plugins are now properly filtered when using `--only` and `--skip` flags.

- [#&#8203;10669](biomejs/biome#10669) [`aa0a6eb`](biomejs/biome@aa0a6eb) Thanks [@&#8203;Netail](https://github.com/Netail)! - Fixed [#&#8203;10651](biomejs/biome#10651): [useInlineScriptId](https://biomejs.dev/linter/rules/use-inline-script-id/) now correctly trims trivia to detect if an id attribute has been set.

- [#&#8203;10689](biomejs/biome#10689) [`844b1be`](biomejs/biome@844b1be) Thanks [@&#8203;ematipico](https://github.com/ematipico)! - Fixed [#&#8203;10658](biomejs/biome#10658). The issue was caused by the "Go-to definition" editor feature, which was enabled by default. The feature is now **disabled by default**. To work, the feature triggers the scanner to build the module graph. This caused memory leak issues in cases where Biome starts in the home directory to modify files.

  If you relied on this new feature, you must now turn on using the \[editor settings] of the extension e.g. [Zed](https://biomejs.dev/reference/zed/#goto_definition) and [VSCode](https://biomejs.dev/reference/vscode/#biomegotodefinition).

- [#&#8203;10695](biomejs/biome#10695) [`043fbb5`](biomejs/biome@043fbb5) Thanks [@&#8203;ematipico](https://github.com/ematipico)! - Fixed [#&#8203;10674](biomejs/biome#10674). Biome now throws an error when the field `level` is missing from a rule option.

- [#&#8203;10712](biomejs/biome#10712) [`5941df2`](biomejs/biome@5941df2) Thanks [@&#8203;Conaclos](https://github.com/Conaclos)! - Improved the diagnostic and the documentation of [`useFlatMap`](https://biomejs.dev/linter/rules/use-flat-map/).

- [#&#8203;10615](biomejs/biome#10615) [`23814f1`](biomejs/biome@23814f1) Thanks [@&#8203;qwertycxz](https://github.com/qwertycxz)! - Improved the DX the JSON schema when it's used by certain code editors like VSCode.

- [#&#8203;10688](biomejs/biome#10688) [`ec69489`](biomejs/biome@ec69489) Thanks [@&#8203;ematipico](https://github.com/ematipico)! - Fixed a bug where the Biome Daemon did not correctly shut down when the editor was closed during an in-progress operation, especially while scanning.

- [#&#8203;10701](biomejs/biome#10701) [`6c2e0d7`](biomejs/biome@6c2e0d7) Thanks [@&#8203;ematipico](https://github.com/ematipico)! - Fixed [#&#8203;10694](biomejs/biome#10694). The Biome Language Server no longer prints an error when the user hovers a variable imported from node\_modules.

- [#&#8203;10681](biomejs/biome#10681) [`888515b`](biomejs/biome@888515b) Thanks [@&#8203;Conaclos](https://github.com/Conaclos)! - Fixed [`useExportType`](https://biomejs.dev/linter/rules/use-export-type/) that reported useless details in some diagnostics.

- [#&#8203;10220](biomejs/biome#10220) [`3694a13`](biomejs/biome@3694a13) Thanks [@&#8203;theBGuy](https://github.com/theBGuy)! - Fixed [`useAnchorContent`](https://biomejs.dev/linter/rules/use-anchor-content/) false positive for `<a>` elements used as render prop values (e.g. `render={<a href="..." />}`), a pattern where the receiving component renders its children inside the anchor element.

- [#&#8203;10702](biomejs/biome#10702) [`98823fb`](biomejs/biome@98823fb) Thanks [@&#8203;ematipico](https://github.com/ematipico)! - Fixed [#&#8203;10612](biomejs/biome#10612). The Biome parser now correctly parses processing instructions. The following SVG doesn't throw errors anymore:

  ```svg
  <?xml version="1.0" encoding="UTF-8" ?>

  <svg></svg>
  ```

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yMzQuMCIsInVwZGF0ZWRJblZlciI6IjQzLjIzNC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Reviewed-on: https://git.oirnoir.dev/OIRNOIR/YouTube-Helper-Server/pulls/21
OIRNOIR pushed a commit to OIRNOIR/YouTube-Helper-Client that referenced this pull request Jun 30, 2026
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@biomejs/biome](https://biomejs.dev) ([source](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome)) | imports | patch | [`2.5.0` -> `2.5.1`](https://renovatebot.com/diffs/npm/@biomejs%2fbiome/2.5.0/2.5.1) |

---

### Release Notes

<details>
<summary>biomejs/biome (@&#8203;biomejs/biome)</summary>

### [`v2.5.1`](https://github.com/biomejs/biome/blob/HEAD/packages/@&#8203;biomejs/biome/CHANGELOG.md#251)

[Compare Source](https://github.com/biomejs/biome/compare/@biomejs/biome@2.5.0...@biomejs/biome@2.5.1)

##### Patch Changes

- [#&#8203;10722](biomejs/biome#10722) [`f8a303d`](biomejs/biome@f8a303d) Thanks [@&#8203;denbezrukov](https://github.com/denbezrukov)! - Fixed CSS formatter output for comments between import media queries.

  ```diff
  -@&#8203;import url("print.css") print,
  -/* comment */
  -screen;
  +@&#8203;import url("print.css") print, /* comment */ screen;
  ```

- [#&#8203;10738](biomejs/biome#10738) [`9fdc560`](biomejs/biome@9fdc560) Thanks [@&#8203;JamBalaya56562](https://github.com/JamBalaya56562)! - Fixed [#&#8203;9899](biomejs/biome#9899): the `json` and `json-pretty` reporters now escape backslashes in a diagnostic's `location.path`. Previously, paths containing backslashes (such as Windows-style paths) were emitted unescaped, producing invalid JSON.

  ```diff
  -    "path": "src\account\setup-passkey.tsx",
  +    "path": "src\\account\\setup-passkey.tsx",
  ```

- [#&#8203;10626](biomejs/biome#10626) [`5f837df`](biomejs/biome@5f837df) Thanks [@&#8203;tom-groves](https://github.com/tom-groves)! - Fixed [#&#8203;10625](biomejs/biome#10625): `biome migrate` no longer emits an invalid trailing comma when a renamed rule (such as `noConsoleLog` → `noConsole`) is the last member of its rule group. Previously this produced malformed output that aborted the migration of a strict-JSON `biome.json` with a parsing error.

- [#&#8203;10535](biomejs/biome#10535) [`c245f9d`](biomejs/biome@c245f9d) Thanks [@&#8203;Mokto](https://github.com/Mokto)! - Fixed a false positive in [`noUnusedVariables`](https://biomejs.dev/linter/rules/no-unused-variables/) for Svelte files where variables referenced inside `{@&#8203;html expr}` blocks were incorrectly reported as unused.

- [#&#8203;10668](biomejs/biome#10668) [`a0f197e`](biomejs/biome@a0f197e) Thanks [@&#8203;Netail](https://github.com/Netail)! - The `biome init` command has been updated to include a more up-to-date URL to [the first-party extensions page](https://biomejs.dev/editors/first-party-extensions/).

- [#&#8203;10667](biomejs/biome#10667) [`d8c3e87`](biomejs/biome@d8c3e87) Thanks [@&#8203;Netail](https://github.com/Netail)! - Fixed [#&#8203;10664](biomejs/biome#10664): [useErrorCause](https://biomejs.dev/linter/rules/use-error-cause/) now correctly detects a shorthand property.

- [#&#8203;10696](biomejs/biome#10696) [`ef2373f`](biomejs/biome@ef2373f) Thanks [@&#8203;ematipico](https://github.com/ematipico)! - Fixed [#&#8203;9566](biomejs/biome#9566). Improved how the Biome Language Server loads multiple configuration files inside a workspace.

- [#&#8203;10705](biomejs/biome#10705) [`4ccb410`](biomejs/biome@4ccb410) Thanks [@&#8203;ematipico](https://github.com/ematipico)! - Fixed [#&#8203;10652](biomejs/biome#10652). Biome plugins are now properly filtered when using `--only` and `--skip` flags.

- [#&#8203;10669](biomejs/biome#10669) [`aa0a6eb`](biomejs/biome@aa0a6eb) Thanks [@&#8203;Netail](https://github.com/Netail)! - Fixed [#&#8203;10651](biomejs/biome#10651): [useInlineScriptId](https://biomejs.dev/linter/rules/use-inline-script-id/) now correctly trims trivia to detect if an id attribute has been set.

- [#&#8203;10689](biomejs/biome#10689) [`844b1be`](biomejs/biome@844b1be) Thanks [@&#8203;ematipico](https://github.com/ematipico)! - Fixed [#&#8203;10658](biomejs/biome#10658). The issue was caused by the "Go-to definition" editor feature, which was enabled by default. The feature is now **disabled by default**. To work, the feature triggers the scanner to build the module graph. This caused memory leak issues in cases where Biome starts in the home directory to modify files.

  If you relied on this new feature, you must now turn on using the \[editor settings] of the extension e.g. [Zed](https://biomejs.dev/reference/zed/#goto_definition) and [VSCode](https://biomejs.dev/reference/vscode/#biomegotodefinition).

- [#&#8203;10695](biomejs/biome#10695) [`043fbb5`](biomejs/biome@043fbb5) Thanks [@&#8203;ematipico](https://github.com/ematipico)! - Fixed [#&#8203;10674](biomejs/biome#10674). Biome now throws an error when the field `level` is missing from a rule option.

- [#&#8203;10712](biomejs/biome#10712) [`5941df2`](biomejs/biome@5941df2) Thanks [@&#8203;Conaclos](https://github.com/Conaclos)! - Improved the diagnostic and the documentation of [`useFlatMap`](https://biomejs.dev/linter/rules/use-flat-map/).

- [#&#8203;10615](biomejs/biome#10615) [`23814f1`](biomejs/biome@23814f1) Thanks [@&#8203;qwertycxz](https://github.com/qwertycxz)! - Improved the DX the JSON schema when it's used by certain code editors like VSCode.

- [#&#8203;10688](biomejs/biome#10688) [`ec69489`](biomejs/biome@ec69489) Thanks [@&#8203;ematipico](https://github.com/ematipico)! - Fixed a bug where the Biome Daemon did not correctly shut down when the editor was closed during an in-progress operation, especially while scanning.

- [#&#8203;10701](biomejs/biome#10701) [`6c2e0d7`](biomejs/biome@6c2e0d7) Thanks [@&#8203;ematipico](https://github.com/ematipico)! - Fixed [#&#8203;10694](biomejs/biome#10694). The Biome Language Server no longer prints an error when the user hovers a variable imported from node\_modules.

- [#&#8203;10681](biomejs/biome#10681) [`888515b`](biomejs/biome@888515b) Thanks [@&#8203;Conaclos](https://github.com/Conaclos)! - Fixed [`useExportType`](https://biomejs.dev/linter/rules/use-export-type/) that reported useless details in some diagnostics.

- [#&#8203;10220](biomejs/biome#10220) [`3694a13`](biomejs/biome@3694a13) Thanks [@&#8203;theBGuy](https://github.com/theBGuy)! - Fixed [`useAnchorContent`](https://biomejs.dev/linter/rules/use-anchor-content/) false positive for `<a>` elements used as render prop values (e.g. `render={<a href="..." />}`), a pattern where the receiving component renders its children inside the anchor element.

- [#&#8203;10702](biomejs/biome#10702) [`98823fb`](biomejs/biome@98823fb) Thanks [@&#8203;ematipico](https://github.com/ematipico)! - Fixed [#&#8203;10612](biomejs/biome#10612). The Biome parser now correctly parses processing instructions. The following SVG doesn't throw errors anymore:

  ```svg
  <?xml version="1.0" encoding="UTF-8" ?>

  <svg></svg>
  ```

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yMzQuMCIsInVwZGF0ZWRJblZlciI6IjQzLjIzNC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Reviewed-on: https://git.oirnoir.dev/OIRNOIR/YouTube-Helper-Client/pulls/8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Linter Area: linter L-JavaScript Language: JavaScript and super languages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants