fix: level is now mandatory (#10695)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

Author: ematipico

.changeset/olive-cameras-swim.md

@@ -0,0 +1,5 @@
+---
+"@biomejs/biome": patch
+---
+
+Fixed [#10674](https://github.com/biomejs/biome/issues/10674). Biome now throws an error when the field `level` is missing from a rule option.

crates/biome_configuration/src/analyzer/mod.rs

@@ -431,6 +431,7 @@ impl Merge for RuleAssistPlainConfiguration {
 #[serde(rename_all = "camelCase", deny_unknown_fields)]
 pub struct RuleAssistWithOptions<T: Default> {
     /// The severity of the emitted diagnostics by the rule
+    #[deserializable(required)]
     pub level: RuleAssistPlainConfiguration,
     /// Rule's options
     pub options: T,
@@ -472,6 +473,7 @@ where
 #[serde(rename_all = "camelCase", deny_unknown_fields)]
 pub struct RuleWithOptions<T: Default + Merge> {
     /// The severity of the emitted diagnostics by the rule
+    #[deserializable(required)]
     pub level: RulePlainConfiguration,
     /// Rule's options
     #[serde(default)]
@@ -518,6 +520,7 @@ where
 #[serde(rename_all = "camelCase", deny_unknown_fields)]
 pub struct RuleWithFixOptions<T: Default + Merge> {
     /// The severity of the emitted diagnostics by the rule
+    #[deserializable(required)]
     pub level: RulePlainConfiguration,
     /// The kind of the code actions emitted by the rule
     #[serde(skip_serializing_if = "Option::is_none")]

crates/biome_configuration/tests/invalid/rule_without_level.json

@@ -0,0 +1,9 @@
+{
+  "linter": {
+    "rules": {
+      "suspicious": {
+        "noDebugger": {}
+      }
+    }
+  }
+}

crates/biome_configuration/tests/invalid/rule_without_level.json.snap

@@ -0,0 +1,14 @@
+---
+source: crates/biome_configuration/tests/spec_tests.rs
+expression: rule_without_level.json
+---
+rule_without_level.json:5:23 deserialize ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  × The key `level` is missing.
+  
+    3 │     "rules": {
+    4 │       "suspicious": {
+  > 5 │         "noDebugger": {}
+      │                       ^^
+    6 │       }
+    7 │     }

crates/biome_configuration/tests/valid/level.json

@@ -0,0 +1,14 @@
+{
+  "linter": {
+    "rules": {
+      "style": {
+        "useNamingConvention": {
+          "level": "off",
+          "options": {
+            "strictCase": false
+          }
+        }
+      }
+    }
+  }
+}

crates/biome_deserialize_macros/src/deserializable_derive.rs

@@ -9,8 +9,8 @@ use crate::deserializable_derive::struct_field_attrs::StructFieldAttrs;
 use biome_string_case::Case;
 use proc_macro_error2::*;
 use proc_macro2::{Ident, TokenStream};
-use quote::quote;
-use syn::{Data, GenericParam, Generics, Path, Type};
+use quote::{format_ident, quote};
+use syn::{Data, GenericParam, Generics, Path};
 
 pub(crate) struct DeriveInput {
     pub ident: Ident,
@@ -75,10 +75,8 @@ impl DeriveInput {
                         let fields = data
                             .fields
                             .into_iter()
-                            .filter_map(|field| {
-                                field.ident.map(|ident| (ident, field.attrs, field.ty))
-                            })
-                            .filter_map(|(ident, attrs, ty)| {
+                            .filter_map(|field| field.ident.map(|ident| (ident, field.attrs)))
+                            .filter_map(|(ident, attrs)| {
                                 let attrs = StructFieldAttrs::try_from(&attrs)
                                     .expect("Could not parse field attributes");
                                 if attrs.skip {
@@ -108,7 +106,6 @@ impl DeriveInput {
                                     ident,
                                     key,
                                     required: attrs.required,
-                                    ty,
                                     validate: attrs.validate,
                                 })
                             })
@@ -202,7 +199,6 @@ pub struct DeserializableFieldData {
     ident: Ident,
     key: String,
     required: bool,
-    ty: Type,
     validate: Option<Path>,
 }
 
@@ -351,11 +347,18 @@ fn generate_deserializable_struct(
         .fields
         .into_iter()
         .map(|field_data| {
+            let is_required = field_data.required;
             let DeserializableFieldData {
                 ident: field_ident,
                 key,
                 ..
             } = field_data;
+            let mark_seen = if is_required {
+                let seen_ident = format_ident!("seen_{}", field_ident);
+                quote! { #seen_ident = true; }
+            } else {
+                quote! {}
+            };
             let deprecation_notice = field_data.deprecated.map(|deprecated| match deprecated {
                 DeprecatedField::Message(message) => quote! {
                     ctx.report(DeserializationDiagnostic::new_deprecated(
@@ -386,6 +389,7 @@ fn generate_deserializable_struct(
 
             quote! {
                 #key => {
+                    #mark_seen
                     match Deserializable::deserialize(ctx, &value, &key_text)#validate {
                         Some(value) => {
                             #deprecation_notice
@@ -398,6 +402,13 @@ fn generate_deserializable_struct(
         })
         .collect();
 
+    let seen_declarations: Vec<_> = required_fields
+        .iter()
+        .map(|field_data| {
+            let seen_ident = format_ident!("seen_{}", field_data.ident);
+            quote! { let mut #seen_ident = false; }
+        })
+        .collect();
     let validator = if required_fields.is_empty() {
         quote! {}
     } else {
@@ -406,14 +417,10 @@ fn generate_deserializable_struct(
             .map(|field_data| &field_data.key)
             .collect();
         let required_fields = required_fields.iter().map(|field_data| {
-            let DeserializableFieldData {
-                ident: field_ident,
-                key,
-                ty,
-                ..
-            } = field_data;
+            let DeserializableFieldData { ident, key, .. } = field_data;
+            let seen_ident = format_ident!("seen_{}", ident);
             quote! {
-                if result.#field_ident == #ty::default() {
+                if !#seen_ident {
                     ctx.report(DeserializationDiagnostic::new_missing_key(
                         #key,
                         range,
@@ -496,6 +503,7 @@ fn generate_deserializable_struct(
                     ) -> Option<Self::Output> {
                         use biome_deserialize::{Deserializable, DeserializationDiagnostic, Text};
                         let mut result: Self::Output = Self::Output::default();
+                        #(#seen_declarations)*
                         for (key, value) in members.flatten() {
                             let Some(key_text) = Text::deserialize(ctx, &key, "") else {
                                 continue;