Skip to content

Support authentication in contrib/push-all.bzl #1728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uhthomas merged 1 commit into from
Oct 6, 2022
Merged

Support authentication in contrib/push-all.bzl #1728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions contrib/push-all.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,13 @@ def _impl(ctx):
pusher_args += ["--stamp-info-file=%s" % _get_runfile_path(ctx, f) for f in stamp_inputs]
pusher_args.append("--dst={}".format(tag))
pusher_args.append("--format={}".format(ctx.attr.format))

# If the docker toolchain is configured to use a custom client config
# directory, use that instead
toolchain_info = ctx.toolchains["@io_bazel_rules_docker//toolchains/docker:toolchain_type"].info
if toolchain_info.client_config != "":
pusher_args += ["-client-config-dir", str(toolchain_info.client_config)]

out = ctx.actions.declare_file("%s.%d.push" % (ctx.label.name, index))
ctx.actions.expand_template(
template = ctx.file._tag_tpl,
Expand Down Expand Up @@ -125,6 +132,7 @@ container_push = rule(
),
},
executable = True,
toolchains = ["@io_bazel_rules_docker//toolchains/docker:toolchain_type"],
implementation = _impl,
)

Expand Down