Support authentication in contrib/push-all.bzl - #1728
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aherrmann The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. |
|
This feature is still useful to us. |
|
This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. |
|
This feature is still useful to us. |
|
This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. |
|
Is there any chance to get a review on this? It's been open for 1.5 years now. @uhthomas perhaps? |
This adds support for authentication to
contrib/push-all.bzlvia credentials defined in a Docker client config defined usingdocker_toolchain_configure. The implementation follows the example ofcontainer_push.I'm not sure how to add a test-case for this. Any pointers?