Fix Automatic-Module-Names to use underscores instead of dashes (not … - #297
Merged
Conversation
…allowed by JPMS).
This was referenced Aug 4, 2021
Codecov Report
@@ Coverage Diff @@
## master #297 +/- ##
=========================================
Coverage 58.88% 58.88%
Complexity 1205 1205
=========================================
Files 131 131
Lines 5071 5071
Branches 593 593
=========================================
Hits 2986 2986
Misses 1809 1809
Partials 276 276 Continue to review full report at Codecov.
|
anuraaga
approved these changes
Aug 5, 2021
Contributor
|
Thanks - yeah underscore seems better than dots. |
willarmiros
approved these changes
Aug 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…allowed by JPMS).
Issue #, if available:
Description of changes:
I made a mistake in #295 - dashes are not allowed in module names. This PR uses underscores instead. I also opened #296 which uses dots - I'll leave the choice up to the maintainers :).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.