Skip to content

Commit a94a013

Browse files
willarmirosAnuraag Agrawal
andauthored
disable fail on empty beans serializer (#293)
Co-authored-by: Anuraag Agrawal <aanuraag@amazon.co.jp>
1 parent d9d17ec commit a94a013

2 files changed

Lines changed: 14 additions & 0 deletions

File tree

aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/entities/EntityImpl.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import com.fasterxml.jackson.databind.ObjectMapper;
2929
import com.fasterxml.jackson.databind.PropertyNamingStrategy;
3030
import com.fasterxml.jackson.databind.SerializationConfig;
31+
import com.fasterxml.jackson.databind.SerializationFeature;
3132
import com.fasterxml.jackson.databind.annotation.JsonSerialize;
3233
import com.fasterxml.jackson.databind.module.SimpleModule;
3334
import com.fasterxml.jackson.databind.node.NullNode;
@@ -58,6 +59,7 @@ public abstract class EntityImpl implements Entity {
5859
@Deprecated
5960
protected static final ObjectMapper mapper = new ObjectMapper()
6061
.findAndRegisterModules()
62+
.configure(SerializationFeature.FAIL_ON_EMPTY_BEANS, false)
6163
.setPropertyNamingStrategy(PropertyNamingStrategy.CAMEL_CASE_TO_LOWER_CASE_WITH_UNDERSCORES)
6264
.setSerializationInclusion(JsonInclude.Include.NON_EMPTY);
6365

aws-xray-recorder-sdk-core/src/test/java/com/amazonaws/xray/entities/EntityTest.java

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,4 +67,16 @@ void testDateSerialization() {
6767
String expected = "{\"default\":{\"date\":1616559298000}}";
6868
assertThat(serializedSeg).contains(expected);
6969
}
70+
71+
@Test
72+
void testUnknownClassSerialization() {
73+
Segment seg = new SegmentImpl(AWSXRay.getGlobalRecorder(), "test");
74+
seg.putAws("coolService", new EmptyBean());
75+
seg.end();
76+
seg.serialize(); // Verify we don't crash here
77+
}
78+
79+
static class EmptyBean {
80+
String otherField = "cerealization";
81+
}
7082
}

0 commit comments

Comments
 (0)