misc crates: drop `SysvarSerialize` by grod220 · Pull Request #14284 · anza-xyz/agave

grod220 · 2026-08-03T10:55:53Z

Removes the last bit of direct SysvarSerialize usage. Next is remaining test helpers.

Continuing to break down #12245. Progresses #10672.

grod220 · 2026-08-03T10:56:47Z

    {
        let mut account = AccountSharedData::new(1, solana_epoch_schedule::SIZE, &sysvar::id());
-        bincode::serialize_into(account.data_as_mut_slice(), &EpochSchedule::default()).unwrap();
+        wincode::serialize_into(account.data_as_mut_slice(), &EpochSchedule::default()).unwrap();


Follow up from #14246 (comment)

grod220 · 2026-08-03T10:58:38Z

-            // Slot History
-            // (Not fixed-size, but also not supported)
-            msg!("SlotHistory identifier:");
-            sysvar::slot_history::id().log();
-            assert_eq!(
-                Err(ProgramError::UnsupportedSysvar),
-                SlotHistory::from_account_info(&accounts[8])
-            );


Not something we can assert anymore as SlotHistory::from_account_info() isn't used anymore. But it anyway just existed to test that SysvarSerialize method couldn't be used for this sysvar.

The purpose of this test is to demonstrate that the syscall doesn't support SlotHistory, not the API:

agave/program-runtime/src/sysvar_cache.rs

Lines 107 to 126 in 7976b4a

// this is exposed for SyscallGetSysvar and should not otherwise be used

pub fn sysvar_id_to_buffer(&self, sysvar_id: &Pubkey) -> &Option<Vec<u8>> {

if Clock::check_id(sysvar_id) {

&self.clock

} else if EpochSchedule::check_id(sysvar_id) {

&self.epoch_schedule

} else if EpochRewards::check_id(sysvar_id) {

&self.epoch_rewards

} else if Rent::check_id(sysvar_id) {

&self.rent

} else if SlotHashes::check_id(sysvar_id) {

&self.slot_hashes

} else if StakeHistory::check_id(sysvar_id) {

&self.stake_history

} else if LastRestartSlot::check_id(sysvar_id) {

&self.last_restart_slot

} else {

&None

}

}

The intent of the test is to make sure that using the syscalls is the same as deserializing from the account passed in.

In that spirit, it would be good to compare some slice of the sysvar account with the corresponding slice from the result of the syscall.

The rest of the assertions in this section are comparing deserialized account sysvars are equivalent to the syscall values. We can't quite do that cleanly for SlotHistory, but I can manually inspect some account bytes as suggested and also assert a failure in the syscall.

grod220 · 2026-08-03T11:01:08Z

 solana-svm-type-overrides = { path = "../../svm-type-overrides", version = "=4.3.0-alpha.2" }
 solana-system-interface = { version = "=3.2", features = ["bincode"] }
 solana-sysvar = "=4.1.0"
+solana-sysvar-id = "=3.1.0"


Sdk libraries seems to require = here

They're just tests, so it's not a huge deal. We could probably relax all those deps in a future PR

grod220 · 2026-08-03T11:01:33Z

 solana-vote-program = { path = "../../programs/vote", version = "=4.3.0-alpha.2" }
 test-case = "3.3.1"
 thiserror = "2.0"
+wincode = { version = "0.5.5", default-features = false }


default-features = false to avoid bringing in std given this is programs context

codecov-commenter · 2026-08-03T12:03:11Z

Codecov Report

❌ Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.9%. Comparing base (6bd615d) to head (62d5bb5).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #14284   +/-   ##
=======================================
  Coverage    81.9%    81.9%           
=======================================
  Files         914      914           
  Lines      356973   356976    +3     
=======================================
+ Hits       292617   292626    +9     
+ Misses      64356    64350    -6

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

buffalojoec · 2026-08-04T09:56:33Z

 solana-core = { workspace = true, features = ["dev-context-only-utils"] }
 solana-cost-model = { workspace = true }
 solana-entry = { workspace = true }
+solana-epoch-schedule = { version = "3.2.0", features = ["wincode"] }


Why not use the workspace version?

True. It's workspace is the dev-bins. Moved.

buffalojoec · 2026-08-04T10:04:16Z

-            // Slot History
-            // (Not fixed-size, but also not supported)
-            msg!("SlotHistory identifier:");
-            sysvar::slot_history::id().log();
-            assert_eq!(
-                Err(ProgramError::UnsupportedSysvar),
-                SlotHistory::from_account_info(&accounts[8])
-            );


The purpose of this test is to demonstrate that the syscall doesn't support SlotHistory, not the API:

agave/program-runtime/src/sysvar_cache.rs

Lines 107 to 126 in 7976b4a

// this is exposed for SyscallGetSysvar and should not otherwise be used

pub fn sysvar_id_to_buffer(&self, sysvar_id: &Pubkey) -> &Option<Vec<u8>> {

if Clock::check_id(sysvar_id) {

&self.clock

} else if EpochSchedule::check_id(sysvar_id) {

&self.epoch_schedule

} else if EpochRewards::check_id(sysvar_id) {

&self.epoch_rewards

} else if Rent::check_id(sysvar_id) {

&self.rent

} else if SlotHashes::check_id(sysvar_id) {

&self.slot_hashes

} else if StakeHistory::check_id(sysvar_id) {

&self.stake_history

} else if LastRestartSlot::check_id(sysvar_id) {

&self.last_restart_slot

} else {

&None

}

}

joncinque

Looks good to me with Joe's comments resolved!

joncinque · 2026-08-04T17:41:16Z

 solana-svm-type-overrides = { path = "../../svm-type-overrides", version = "=4.3.0-alpha.2" }
 solana-system-interface = { version = "=3.2", features = ["bincode"] }
 solana-sysvar = "=4.1.0"
+solana-sysvar-id = "=3.1.0"


They're just tests, so it's not a huge deal. We could probably relax all those deps in a future PR

joncinque · 2026-08-04T17:50:22Z

-            // Slot History
-            // (Not fixed-size, but also not supported)
-            msg!("SlotHistory identifier:");
-            sysvar::slot_history::id().log();
-            assert_eq!(
-                Err(ProgramError::UnsupportedSysvar),
-                SlotHistory::from_account_info(&accounts[8])
-            );


The intent of the test is to make sure that using the syscalls is the same as deserializing from the account passed in.

In that spirit, it would be good to compare some slice of the sysvar account with the corresponding slice from the result of the syscall.

buffalojoec

Works for me, thanks!

grod220 requested a review from a team as a code owner August 3, 2026 10:55

grod220 commented Aug 3, 2026

View reviewed changes

grod220 force-pushed the serialize-direct-cont branch 2 times, most recently from a6430ae to ca002d8 Compare August 3, 2026 11:13

grod220 requested review from buffalojoec and joncinque August 3, 2026 12:10

buffalojoec reviewed Aug 4, 2026

View reviewed changes

joncinque reviewed Aug 4, 2026

View reviewed changes

grod220 added 4 commits August 5, 2026 09:48

remove remaining direct SysvarSerialize usage

d97330f

move dep to workspace

d6aad92

SlotHistory sysvar/call assertion

132e0f9

SlotHashes sysvar/call assertion

5dc6572

grod220 force-pushed the serialize-direct-cont branch from ca002d8 to 5dc6572 Compare August 5, 2026 09:34

fix dep version

62d5bb5

grod220 requested review from buffalojoec and joncinque August 5, 2026 10:27

buffalojoec approved these changes Aug 5, 2026

View reviewed changes

joncinque approved these changes Aug 5, 2026

View reviewed changes

grod220 added this pull request to the merge queue Aug 5, 2026

Merged via the queue into anza-xyz:master with commit 47c6082 Aug 5, 2026
50 checks passed

grod220 deleted the serialize-direct-cont branch August 5, 2026 12:59

grod220 mentioned this pull request Aug 11, 2026

Own sysvar account serialization, drop SysvarSerialize #12245

Closed

2 tasks

	// this is exposed for SyscallGetSysvar and should not otherwise be used
	pub fn sysvar_id_to_buffer(&self, sysvar_id: &Pubkey) -> &Option<Vec<u8>> {
	if Clock::check_id(sysvar_id) {
	&self.clock
	} else if EpochSchedule::check_id(sysvar_id) {
	&self.epoch_schedule
	} else if EpochRewards::check_id(sysvar_id) {
	&self.epoch_rewards
	} else if Rent::check_id(sysvar_id) {
	&self.rent
	} else if SlotHashes::check_id(sysvar_id) {
	&self.slot_hashes
	} else if StakeHistory::check_id(sysvar_id) {
	&self.stake_history
	} else if LastRestartSlot::check_id(sysvar_id) {
	&self.last_restart_slot
	} else {
	&None
	}
	}

Uh oh!

Conversation

grod220 commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

joncinque left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

buffalojoec left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

grod220 commented Aug 3, 2026 •

edited

Loading

codecov-commenter commented Aug 3, 2026 •

edited

Loading