syscalls & program-runtime: drop SysvarSerialize - #14246
Merged
Merged
Conversation
grod220
force-pushed
the
syscalls-serialize
branch
from
July 31, 2026 12:10
0fe3cf8 to
aae922c
Compare
grod220
force-pushed
the
syscalls-serialize
branch
from
July 31, 2026 12:50
aae922c to
18f4ae5
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #14246 +/- ##
=========================================
- Coverage 82.0% 82.0% -0.1%
=========================================
Files 899 899
Lines 354244 354275 +31
=========================================
- Hits 290625 290562 -63
- Misses 63619 63713 +94 🚀 New features to boost your workflow:
|
buffalojoec
approved these changes
Aug 1, 2026
joncinque
reviewed
Aug 1, 2026
| create_account_shared_data_for_test(&EpochSchedule::default()), | ||
| )); | ||
| let mut account = AccountSharedData::new(1, solana_epoch_schedule::SIZE, &sysvar::id()); | ||
| bincode::serialize_into(account.data_as_mut_slice(), &EpochSchedule::default()).unwrap(); |
There was a problem hiding this comment.
Not a big deal, but why is this using bincode instead of wincode?
There was a problem hiding this comment.
maybe too conservative, but separating this refactor and actual switch to wincode isn't such a bad idea
Author
There was a problem hiding this comment.
Whoops, didn't look hard enough to see if EpochSchedule had wincode attrs. Though, this is a test utility, so low impact regardless.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing to break down #12245. Progresses #10672.