Skip to content

Support static IPv6 address - #125

Merged
haiyuazhang merged 3 commits into
ansible-collections:devfrom
Fred-sun:update_publicipaddress
Sep 9, 2020
Merged

Support static IPv6 address#125
haiyuazhang merged 3 commits into
ansible-collections:devfrom
Fred-sun:update_publicipaddress

Conversation

@Fred-sun

@Fred-sun Fred-sun commented May 19, 2020

Copy link
Copy Markdown
Collaborator
SUMMARY

Update azure_rm_publicipaddress model, fixes #110 .

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_publicipaddress

ADDITIONAL INFORMATION

@Fred-sun Fred-sun changed the title Update azure_rm_publicipaddress [WIP]Update azure_rm_publicipaddress May 21, 2020
@haiyuazhang
haiyuazhang force-pushed the dev branch 2 times, most recently from 57c6057 to 3e1c870 Compare July 3, 2020 18:05
@aardbol

aardbol commented Jul 20, 2020

Copy link
Copy Markdown

Your modification is wrong. This fixes the SKU issue:
public_ip_allocation_method=self.allocation_method if self.sku == 'Basic' else 'Static',

This is due to the Standard SKU only supported the Static allocation method for both IPv4 and IPv6.

Also, please don't forget to add this to the allocation_method description documentation:
- Is always Static when Standard SKU is used

@Fred-sun

Copy link
Copy Markdown
Collaborator Author

Your modification is wrong. This fixes the SKU issue:
public_ip_allocation_method=self.allocation_method if self.sku == 'Basic' else 'Static',

This is due to the Standard SKU only supported the Static allocation method for both IPv4 and IPv6.

Also, please don't forget to add this to the allocation_method description documentation:
- Is always Static when Standard SKU is used

@aardbol Thank you for your suggestion. I don't think there is any need to add judgments. What kind of parameter configuration should be used instead in the document. Thank you!

@Fred-sun Fred-sun added the ready-for-review The PR is ready to be reviewed and merged. label Aug 24, 2020
@Fred-sun Fred-sun changed the title [WIP]Update azure_rm_publicipaddress Update azure_rm_publicipaddress Sep 3, 2020
@Fred-sun
Fred-sun force-pushed the update_publicipaddress branch from e055282 to cf52c11 Compare September 3, 2020 03:04
@Fred-sun Fred-sun closed this Sep 3, 2020
@Fred-sun
Fred-sun force-pushed the update_publicipaddress branch from cf52c11 to 5f7c079 Compare September 3, 2020 05:29
@Fred-sun Fred-sun reopened this Sep 3, 2020
@Fred-sun Fred-sun changed the title Update azure_rm_publicipaddress Support IPv6 public ip address Sep 9, 2020
@haiyuazhang haiyuazhang changed the title Support IPv6 public ip address Support static IPv6 address Sep 9, 2020
@haiyuazhang
haiyuazhang merged commit 5894e96 into ansible-collections:dev Sep 9, 2020
@Fred-sun
Fred-sun deleted the update_publicipaddress branch December 31, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review The PR is ready to be reviewed and merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

azure_rm_publicipaddress cannot use Standard SKU with IPv6

3 participants