Skip to content

Commit 57c6057

Browse files
haiyuazhanghaiyuazhang
authored andcommitted
* release v0.2.0 preparation and minor ad module bug fixing
1 parent ddefb3d commit 57c6057

12 files changed

Lines changed: 30 additions & 47 deletions

File tree

.idea/.gitignore

Lines changed: 0 additions & 2 deletions
This file was deleted.

.idea/azure.iml

Lines changed: 0 additions & 10 deletions
This file was deleted.

.idea/inspectionProfiles/profiles_settings.xml

Lines changed: 0 additions & 6 deletions
This file was deleted.

.idea/misc.xml

Lines changed: 0 additions & 4 deletions
This file was deleted.

.idea/modules.xml

Lines changed: 0 additions & 8 deletions
This file was deleted.

.idea/vcs.xml

Lines changed: 0 additions & 6 deletions
This file was deleted.

CHANGELOG.md

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,26 @@
11
# Change Log
22

3+
## v0.2.0 (2020-07-03)
4+
5+
### NEW MODULES
6+
- azure_rm_privatezone module ([#122](https://github.com/ansible-collections/azure/pull/122))
7+
- azure_rm_adserviceprincipal module ([#179](https://github.com/ansible-collections/azure/pull/179))
8+
- azure_rm_adserviceprincipal_info module ([#179](https://github.com/ansible-collections/azure/pull/179))
9+
- azure_rm_adpassword module ([#179](https://github.com/ansible-collections/azure/pull/179))
10+
- azure_rm_adpassword_info module ([#179](https://github.com/ansible-collections/azure/pull/179))
11+
12+
### FEATURE ENHANCEMENT
13+
- add ability to remove all subnet service endpoints ([#148](https://github.com/ansible-collections/azure/pull/148))
14+
- update network client api version ([#157](https://github.com/ansible-collections/azure/pull/157))
15+
- add ephemeral os disk support for azure_rm_virualmachinescaleset ([#128](https://github.com/ansible-collections/azure/pull/128))
16+
- add ephemeral os disk support for azure_rm_virtualmachine ([#124](https://github.com/ansible-collections/azure/pull/124))
17+
- add FileEndpoint to azure_rm_storageaccount_info ([#102](https://github.com/ansible-collections/azure/pull/102))
18+
- add support for managing the 'Firewall and virtual networks' settings in azure_rm_storageaccount ([#108](https://github.com/ansible-collections/azure/pull/108))
19+
20+
### BUG FIXING
21+
- bug fixing in azure_rm_aks ([#170](https://github.com/ansible-collections/azure/pull/170))
22+
- migrate missing doc_fragments that went missing ([#115](https://github.com/ansible-collections/azure/pull/115))
23+
324
## v0.1.3 (2020-05-13)
425

526
- add new parameter in azure_rm_aks

galaxy.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ namespace: azure
99
name: azcollection
1010

1111
# The version of the collection. Must be compatible with semantic versioning
12-
version: 0.1.3
12+
version: 0.2.0
1313

1414
# The path to the Markdown (.md) readme file. This path is relative to the root of the collection
1515
readme: README.md
@@ -18,7 +18,6 @@ readme: README.md
1818
# @nicks:irc/im.site#channel'
1919
authors:
2020
- Microsoft <haiyzhan@microsoft.com>
21-
- Microsoft <jieshe@microsoft.com>
2221

2322

2423
### OPTIONAL but strongly recommended

plugins/modules/azure_rm_adpassword.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@
3030
description:
3131
- The application ID.
3232
type: str
33-
service_principal_id:
33+
service_principal_object_id:
3434
description:
35-
- The service principal ID.
35+
- The service principal object ID.
3636
type: str
3737
key_id:
3838
description:
@@ -129,7 +129,7 @@ def __init__(self):
129129

130130
self.module_arg_spec = dict(
131131
app_id=dict(type='str'),
132-
service_principal_id=dict(type='str'),
132+
service_principal_object_id=dict(type='str'),
133133
app_object_id=dict(type='str'),
134134
key_id=dict(type='str'),
135135
tenant=dict(type='str', required=True),
@@ -141,7 +141,7 @@ def __init__(self):
141141
self.state = None
142142
self.tenant = None
143143
self.app_id = None
144-
self.service_principal_id = None
144+
self.service_principal_object_id = None
145145
self.app_object_id = None
146146
self.key_id = None
147147
self.value = None
@@ -188,12 +188,12 @@ def resolve_app_obj_id(self):
188188
return
189189
elif self.app_id or self.service_principal_object_id:
190190
if not self.app_id:
191-
sp = self.client.service_principals.get(self.service_principal_id)
191+
sp = self.client.service_principals.get(self.service_principal_object_id)
192192
self.app_id = sp.app_id
193193
if not self.app_id:
194194
self.fail("can't resolve app via service principal object id {0}".format(self.service_principal_object_id))
195195

196-
result = list(self.client.applications.list(filter="appId eq {0}".format(self.app_id)))
196+
result = list(self.client.applications.list(filter="appId eq '{}'".format(self.app_id)))
197197
if result:
198198
self.app_object_id = result[0].object_id
199199
else:

plugins/modules/azure_rm_adpassword_info.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ def resolve_app_obj_id(self):
179179
if not self.app_id:
180180
self.fail("can't resolve app via service principal object id {0}".format(self.service_principal_object_id))
181181

182-
result = list(self.client.applications.list(filter="appId eq {0}".format(self.app_id)))
182+
result = list(self.client.applications.list(filter="appId eq '{}'".format(self.app_id)))
183183
if result:
184184
self.app_object_id = result[0].object_id
185185
else:

0 commit comments

Comments
 (0)