Skip to content

View service related imports are made dynamically - #829

Merged
kaisalmen merged 2 commits into
mainfrom
issue-827
Jan 20, 2025
Merged

View service related imports are made dynamically#829
kaisalmen merged 2 commits into
mainfrom
issue-827

Conversation

@kaisalmen

Copy link
Copy Markdown
Collaborator

Fixes #827

Included along:

  • Updated dependencies, especially updated to vitest 3
  • Properly separated langium classic and extend example, because you could only launch the one or the other. Dispose and relaunch is properly working.

- Updated dependencies
- Properly separated langium classic and extend example
@kaisalmen
kaisalmen requested a review from CGNonofr as a code owner January 20, 2025 09:14
@kaisalmen

kaisalmen commented Jan 20, 2025

Copy link
Copy Markdown
Collaborator Author

@CGNonofr do you have time to review/approve that today? I would like to put out a bugfix release.

@CGNonofr CGNonofr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaisalmen
kaisalmen merged commit 607394e into main Jan 20, 2025
@kaisalmen
kaisalmen deleted the issue-827 branch January 20, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

View service type EditorService breaks when importing anything from monaco-editor-wrapper/vscode/services

2 participants