Skip to content

View service type EditorService breaks when importing anything from monaco-editor-wrapper/vscode/services #827

Description

@nk-coding

I want to import checkServiceConsistency from monaco-editor-wrapper/vscode/services (as I do the init manually) and use it with a classic app.
This causes the already known

Error: Unsupported: ViewDescriptorService.getViewContainersByLocation is not supported. You are using a feature without registering the corresponding service override.
    at ViewDescriptorService.unsupported2 (missing-services.js:222:15)
    at getDefaultViewContainer (views.js:309:35)
    at initLayoutState (views.js:317:103)
    at UniqueContainer.value (views.js:333:5)
    at Emitter._deliver (event.js:679:22)
    at Emitter._deliverQueue (event.js:688:18)
    at Emitter.fire (event.js:705:18)
    at lifecycle.js:56:32
    at _InstantiationService.invokeFunction (instantiationService.js:78:20)
    at startup (lifecycle.js:51:31)

error mentioned in other issues.

The reason for this is that monaco-editor-wrapper/vscode/services has export * from './viewsService.js';, which imports @codingame/monaco-vscode-views-service-override, which causes this issue.

Possible fixes:

  • move the import of @codingame/monaco-vscode-views-service-override inside defaultViewsInit (as a dynamic import)
  • declare a new entry point in package.json for the viewsService.ts stuff

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions