fixed example + added it to the build - #25
Merged
Merged
Conversation
This was referenced Aug 25, 2017
gatesn
previously approved these changes
Aug 28, 2017
gatesn
left a comment
gatesn
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me, just need to rebase before merging
Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>
akosyakov
force-pushed
the
ak/fixed_example
branch
from
August 28, 2017 11:01
b3182a3 to
6150019
Compare
Contributor
Author
|
@gatesn Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.