Allow for lazy loading of monaco - #19
Conversation
|
@gatesn please sign off your commit, Does this PR solve an issue with |
807a721 to
c40b409
Compare
|
Signed commit, will check out the react issue as well |
|
Not sure it's worth writing an example here given the amount of duplicated code between the react and non-react examples. Also #16 is already closed. |
|
Would it be possible to add a react page to the existing example? |
|
@akosyakov working on the example, I try to compile it and get this, have you seen it before? Is it an update in the jsonrpc package? |
|
Nice fix! Can this be merged and the react-example added as a separate PR? They don't feel extremely related to me. |
|
@gatesn please use |
|
@jkillian if you don't use |
|
@akosyakov we use monaco's |
akosyakov
left a comment
There was a problem hiding this comment.
Please have a look at comments
|
@gatesn please assign you on #4 (comment) if you are going to tackle the react example. I am fine to make it with the separate PR but please take care of the proper rebasing. |
Signed-off-by: Nicholas Gates <ngates@palantir.com>
7d4b09d to
92fe66d
Compare
|
@gatesn I've sent an invite you that makes you a collaborator. You should be able to merge after accepting it. |
It's fine to
import X = monaco.Xfor types, but not for objects such asmonaco.Uriandmonaco.languages. This PR inlines these references to allow monaco to be loaded lazily.Fixes #16