Bump Monaco to 0.19.3 - #198
Closed
Twinside wants to merge 1 commit into
Closed
Conversation
A new enum has been added to the vscode compatibility layer (as vscode-languageserver rely on it). Also the severity enum converter use an internal version of the enum to avoid relying on the vscode module.
Twinside
requested review from
AlexTugarev,
BroKun,
akosyakov,
asual,
gatesn,
johnwiseheart,
mofux and
rcjsuen
as code owners
January 22, 2020 09:08
|
Open in Gitpod - starts a development workspace for this pull request in code review mode and opens it in a browser IDE. |
Contributor
|
@Twinside I tried to build your changes but got the errors: Looks like the ci-build displays the same. |
Author
|
I'll look at that, I've mainly been interested by making the client work |
Contributor
Contributor
Merged
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new enum has been added to the vscode compatibility layer (as
vscode-languageserver rely on it). Also the severity enum converter
use an internal version of the enum to avoid relying on the vscode
module.
Note: I've tried to create the pull request yesterday several times, to no avail.