Skip to content

DRAFT - Update Language Client to 6.0.0 - #197

Closed
apupier wants to merge 3 commits into
TypeFox:masterfrom
apupier:196-updateLanguageClient
Closed

DRAFT - Update Language Client to 6.0.0#197
apupier wants to merge 3 commits into
TypeFox:masterfrom
apupier:196-updateLanguageClient

Conversation

@apupier

@apupier apupier commented Jan 21, 2020

Copy link
Copy Markdown
  • requires upgrade of TtypeScript to 3.7.5 to avoid error TS1086: An accessor cannot be declared in an ambient context.
  • requires API updates:
    • client/src/monaco-language-client.ts createMessageTransports now
      using Promise instead of Thenable
    • vscode-uri Uri has been renamed URI
    • registerCallHierarchyProvider has moved from workspace to languages

remaining (but didn't grok what it means, I'm a newbie in typescript):

monaco-languageclient: src/vscode-api.ts(209,17): error TS2322: Type
'(arg0: Uri, arg1: readonly Diagnostic[] | undefined) => void' is not
assignable to type '{ (uri: Uri, diagnostics: readonly Diagnostic[] |
undefined): void; (entries: readonly [Uri, readonly Diagnostic[] |
undefined][]): void; }'.

EDIT:
fixed:

monaco-languageclient: src/vscode-api.ts(52,11): error TS2740: Type '{
createFileSystemWatcher(globPattern: GlobPattern, ignoreCreateEvents:
boolean | undefined, ignoreChangeEvents: boolean | undefined,
ignoreDeleteEvents: boolean | undefined): FileSystemWatcher; ... 21 more
...; name: undefined; }' is missing the following properties from type
'typeof workspace': fs, workspaceFile, onWillCreateFiles,
onDidCreateFiles, and 4 more.

@gitpod-io-legacy-app

Copy link
Copy Markdown

Open in Gitpod - starts a development workspace for this pull request in code review mode and opens it in a browser IDE.

@apupier
apupier force-pushed the 196-updateLanguageClient branch from c1f212e to 48ed562 Compare January 21, 2020 13:23
- requires upgrade of TtypeScript to 3.7.5 to avoid "error TS1086: An
accessor cannot be declared in an ambient context.
"
- requires API updates:
-- client/src/monaco-language-client.ts createMessageTransports now
using Promise instead of Thenable
-- vscode-uri Uri has been renamed URI
-- registerCallHierarchyProvider has moved from workspace to languages

remaining:
monaco-languageclient: src/vscode-api.ts(52,11): error TS2740: Type '{
createFileSystemWatcher(globPattern: GlobPattern, ignoreCreateEvents:
boolean | undefined, ignoreChangeEvents: boolean | undefined,
ignoreDeleteEvents: boolean | undefined): FileSystemWatcher; ... 21 more
...; name: undefined; }' is missing the following properties from type
'typeof workspace': fs, workspaceFile, onWillCreateFiles,
onDidCreateFiles, and 4 more.
monaco-languageclient: src/vscode-api.ts(209,17): error TS2322: Type
'(arg0: Uri, arg1: readonly Diagnostic[] | undefined) => void' is not
assignable to type '{ (uri: Uri, diagnostics: readonly Diagnostic[] |
undefined): void; (entries: readonly [Uri, readonly Diagnostic[] |
undefined][]): void; }'.


Signed-off-by: Aurélien Pupier <apupier@redhat.com>
monaco-languageclient: src/vscode-api.ts(52,11): error TS2740: Type '{
createFileSystemWatcher(globPattern: GlobPattern, ignoreCreateEvents:
boolean | undefined, ignoreChangeEvents: boolean | undefined,
ignoreDeleteEvents: boolean | undefined): FileSystemWatcher; ... 21 more
...; name: undefined; }' is missing the following properties from type
'typeof workspace': fs, workspaceFile, onWillCreateFiles,
onDidCreateFiles, and 4 more.

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier
apupier force-pushed the 196-updateLanguageClient branch from 337287d to b5e0e8c Compare January 21, 2020 13:35
@apupier

apupier commented Jan 21, 2020

Copy link
Copy Markdown
Author

hum in fact, seems that compilation errro are nto all reported when there is a previous one, here is a bunch of other:

node-example: src/client.ts(66,57): error TS2345: Argument of type 'import("/home/apupier/git/monaco-languageclient/node_modules/vscode-ws-jsonrpc/node_modules/vscode-jsonrpc/lib/main").MessageConnection' is not assignable to parameter of type 'import("/home/apupier/git/monaco-languageclient/node_modules/vscode-jsonrpc/lib/main").MessageConnection'.
node-example:   Type 'MessageConnection' is missing the following properties from type 'MessageConnection': onProgress, sendProgress, onUnhandledProgress
node-example: src/json-server.ts(7,8): error TS2613: Module '"/home/apupier/git/monaco-languageclient/node_modules/vscode-uri/lib/umd/index"' has no default export. Did you mean to use 'import { URI } from "/home/apupier/git/monaco-languageclient/node_modules/vscode-uri/lib/umd/index"' instead?
node-example: src/json-server.ts(28,36): error TS2554: Expected 1 arguments, but got 0.
node-example: src/json-server.ts(40,43): error TS7006: Parameter 'change' implicitly has an 'any' type.
node-example: src/json-server.ts(43,35): error TS7006: Parameter 'event' implicitly has an 'any' type.

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@RomanNikitenko

Copy link
Copy Markdown
Contributor

hum in fact, seems that compilation errro are nto all reported when there is a previous one, here is a bunch of other:

node-example: src/client.ts(66,57): error TS2345: Argument of type 'import("/home/apupier/git/monaco-languageclient/node_modules/vscode-ws-jsonrpc/node_modules/vscode-jsonrpc/lib/main").MessageConnection' is not assignable to parameter of type 'import("/home/apupier/git/monaco-languageclient/node_modules/vscode-jsonrpc/lib/main").MessageConnection'.
node-example:   Type 'MessageConnection' is missing the following properties from type 'MessageConnection': onProgress, sendProgress, onUnhandledProgress
node-example: src/json-server.ts(7,8): error TS2613: Module '"/home/apupier/git/monaco-languageclient/node_modules/vscode-uri/lib/umd/index"' has no default export. Did you mean to use 'import { URI } from "/home/apupier/git/monaco-languageclient/node_modules/vscode-uri/lib/umd/index"' instead?
node-example: src/json-server.ts(28,36): error TS2554: Expected 1 arguments, but got 0.
node-example: src/json-server.ts(40,43): error TS7006: Parameter 'change' implicitly has an 'any' type.
node-example: src/json-server.ts(43,35): error TS7006: Parameter 'event' implicitly has an 'any' type.

I see similar errors in the PR #198.
I'm investigating how to fix them.

@RomanNikitenko

RomanNikitenko commented Jan 23, 2020

Copy link
Copy Markdown
Contributor

@apupier
Looks like the errors was fixed within your last commit.
Cool!

====

upd: checked - some errors are still there, so continue to investigate how to fix them...

@apupier

apupier commented Mar 12, 2020

Copy link
Copy Markdown
Author

seems #199 is more advanced. Closing this PR

@apupier apupier closed this Mar 12, 2020
@apupier
apupier deleted the 196-updateLanguageClient branch March 12, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants