Implemented support for "LocationLink" in the "onDefinition" method - #191
Merged
Conversation
NLueg
requested review from
AlexTugarev,
BroKun,
akosyakov,
asual,
gatesn,
mofux and
rcjsuen
as code owners
December 6, 2019 11:28
|
Open in Gitpod - starts a development workspace for this pull request in code review mode and opens it in a browser IDE. |
NLueg
changed the title
Collaborator
|
Tested with angular language server which requires it, seems to work fine |
added 2 commits
January 20, 2020 08:32
Contributor
|
@RomanNikitenko could you have a look whether we need this PR as well? |
Merged
60 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the conversion for
LocationLinksin theasDefinitionResultmethod.This closes #190.
During the implementation I oriented myself to the implementation in the VSCode client