Bulk adding new routes - ordering of routes gets scrambled and requires reordering#453
Merged
vnugent merged 4 commits intoOpenBeta:developfrom Mar 18, 2025
Merged
Conversation
Makes logic cleaner, avoids odd double splat syntax
greghart
force-pushed
the
sorted-climb-inputs
branch
from
f53556f to
0fe937f
Compare
Fix issue that popped up from coverage (new should be +1)
greghart
force-pushed
the
sorted-climb-inputs
branch
from
541397d to
5406188
Compare
vnugent
requested changes
Mar 5, 2025
Contributor
|
@all-contributors add @greghart for code & ideas |
Contributor
|
I've put up a pull request to add @greghart! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull request
about: Create a pull request
title: Bulk adding new routes - ordering of routes gets scrambled and requires reordering
labels: bug, feature ?
assignees: Greg Hart
What type of PR is this?(check all applicable)
Description
Per related issue, when adding multiple climbs, we don't persist the ordering
Related Issues
Issue #1255
What this PR achieves
This PR changes
addOrUpdateClimbsto persist the order of incoming arrays of climbs usingleft_right_index(when not already given0.It also formalizes whether new climbs should come after or before existing climbs (when
left_right_indexis not given) -- currently it changes this so new climbs come after instead of before.Screenshots, recordings
Notes