Add coverage for adding climb against existing climbs

Fix issue that popped up from coverage (new should be +1)

Author: greghart

src/model/MutableClimbDataSource.ts

@@ -1,5 +1,5 @@
-import { GraphQLError } from 'graphql'
 import { ApolloServerErrorCode } from '@apollo/server/errors'
+import { GraphQLError } from 'graphql'
 import { ClientSession } from 'mongoose'
 import muid, { MUUID } from 'uuid-mongodb'
 
@@ -10,12 +10,12 @@ import { ChangeRecordMetadataType } from '../db/ChangeLogType.js'
 import { getClimbModel } from '../db/ClimbSchema.js'
 import { ClimbChangeDocType, ClimbChangeInputType, ClimbEditOperationType, ClimbType, IPitch } from '../db/ClimbTypes.js'
 import { aggregateCragStats } from '../db/utils/Aggregate.js'
+import { withTransaction } from '../utils/helpers.js'
 import { sanitize, sanitizeStrict } from '../utils/sanitize.js'
 import ChangeLogDataSource from './ChangeLogDataSource.js'
 import ClimbDataSource from './ClimbDataSource.js'
 import ExperimentalUserDataSource from './ExperimentalUserDataSource.js'
 import MutableAreaDataSource from './MutableAreaDataSource.js'
-import { withTransaction } from '../utils/helpers.js'
 
 export interface AddOrUpdateClimbsOptions {
   userId: MUUID
@@ -110,16 +110,17 @@ export default class MutableClimbDataSource extends ClimbDataSource {
     // when adding new climbs, ensure they are added in expected sort order, such that:
     // * multiple climbs keep the order they're input in.
     // * all newly added climbs come after existing climbs.
-    let newClimbLeftRightIndex = (await this.climbModel
+    const maxExisting = (await this.climbModel
       .find({ _id: { $in: parent.climbs } })
       .select('metadata.left_right_index')
       .sort({ 'metadata.left_right_index': -1 })
-      .limit(1))[0]
-      ?.metadata.left_right_index ?? 1
+      .limit(1))[0]?.metadata.left_right_index
+    let newClimbLeftRightIndex = (maxExisting ?? 0) + 1
+
     function resolveLeftRightIndex (i: number): { left_right_index: number } | null {
       // user input is always prioritized
       if (userInput[i].leftRightIndex !== undefined) {
-        return { left_right_index: userInput[i].leftRightIndex! }
+        return { left_right_index: userInput[i].leftRightIndex ?? 0 }
       }
       // otherwise, auto-order new climbs
       if (!idList[i].existed) {

src/model/__tests__/MutableClimbDataSource.ts

@@ -1,16 +1,16 @@
-import muid from 'uuid-mongodb'
 import { ChangeStream } from 'mongodb'
+import muid from 'uuid-mongodb'
 
-import MutableClimbDataSource from '../MutableClimbDataSource.js'
 import MutableAreaDataSource from '../MutableAreaDataSource.js'
+import MutableClimbDataSource from '../MutableClimbDataSource.js'
 
-import { createIndexes, getAreaModel, getClimbModel } from '../../db/index.js'
-import { logger } from '../../logger.js'
 import { ClimbChangeInputType, ClimbType } from '../../db/ClimbTypes.js'
-import { sanitizeDisciplines } from '../../GradeUtils.js'
 import streamListener from '../../db/edit/streamListener.js'
-import ChangeLogDataSource from '../ChangeLogDataSource.js'
+import { createIndexes, getAreaModel, getClimbModel } from '../../db/index.js'
+import { sanitizeDisciplines } from '../../GradeUtils.js'
+import { logger } from '../../logger.js'
 import inMemoryDB from '../../utils/inMemoryDB.js'
+import ChangeLogDataSource from '../ChangeLogDataSource.js'
 
 export const newSportClimb1: ClimbChangeInputType = {
   name: 'Cool route 1',
@@ -212,7 +212,13 @@ describe('Climb CRUD', () => {
     ).rejects.toThrowError(/You can only add climbs to a crag/)
 
     // Route-only area should accept new boulder problems
-    await climbs.addOrUpdateClimbs(testUser, routesArea.metadata.area_id, [newBoulderProblem1])
+    const [newBoulderID] = await climbs.addOrUpdateClimbs(testUser, routesArea.metadata.area_id, [newBoulderProblem1])
+    // Should come after existing climbs
+    expect(await climbs.findOneClimbByMUUID(muid.from(newBoulderID))).toMatchObject({
+      metadata: {
+        left_right_index: newClimbsToAdd.length + 1
+      }
+    })
   })
 
   it('can add new boulder problems', async () => {