[14.0][MIG] connector by eantones · Pull Request #385 · OCA/connector

eantones · 2020-10-16T18:30:39Z

Depends on:

eantones · 2020-10-16T20:14:24Z

All tests passed perfectly on my test environment
I think there's something wrong with the test-dependencies.txt and travis is not able to clone the queue_job PR.
Any ideas?
Thanks! :-)

sebastienbeau · 2020-12-02T15:21:34Z

@eantones Dependency have been merged
Can you update you commit to remove the test-dependency file ?
Thanks

eantones · 2020-12-02T18:14:40Z

@sebastienbeau done!
Thanks!

guewen · 2020-12-03T06:51:23Z

+from odoo import _, api, fields, models
+
+
+class ConnectorCheckpoint(models.Model):


Maybe the good time to remove this? #351

good idea !

Can this be removed as suggested?

I think so, nobody is using it AFAIK.
@eantones likely this is the last bit 😉

esakarya · 2021-01-13T16:15:25Z

any update ?

kittiu · 2021-03-14T08:52:45Z

@eantones please check travis and rebase. All dependencies are merged.

@job

When the @job is registered and created in the database, it lookups its channel and creates it if it don't exist yet.

…ported fields

…module with caching of the result

…installed

…lass

rvalyi

I checked that the dependencies didn't change much between v13 and v14. Also inside the module components and models have no reason to change to accomodate to any change in Odoo. So given tests are passing, that's LGTM.

rousseldenis

Code review. Maybe increasing a little bit coverage should be great.

@OCA/connector-maintainers We certainly should switch to main branches including non migrated modules from past versions in order to avoid such PR with 721 commits.

guewen · 2021-03-26T10:51:55Z

@OCA/connector-maintainers We certainly should switch to main branches including non migrated modules from past versions in order to avoid such PR with 721 commits.

+1
I did this for the previous versions, but I missed the occasion to ensure this for 14.0

guewen · 2021-03-26T12:46:24Z

@eantones I'm going to propose a PR on your PR to remove checkpoints

Alternatives such as activities can be used.

guewen · 2021-03-26T13:06:45Z

@eantones can you include nuobit#1 please? Then we are good to merge :)

Remove connector checkpoints

eantones · 2021-03-26T13:51:43Z

@guewen done! :-)

eantones · 2021-03-26T14:02:27Z

@guewen @rousseldenis regarding the 721 commits, you're right, there's too many, I can make a squash

rousseldenis · 2021-03-26T14:04:41Z

I can make a squash

No! You'll loose the commit history and that is not wanted.

rousseldenis · 2021-03-26T14:07:32Z

@guewen @rousseldenis regarding the 721 commits, you're right, there's too many, I can make a squash

There are two ways of doing main branches :

Creating the branch with no module at all from scratch (actual OCA convention apart some repos). All migration PR are created with the whole commit history like here.
Creating the new main branch (14.0) based on previous one (13.0). So, the commit history is preserved between them. The advantage is that migration PR would contain only the new commits and is more readable.

eantones · 2021-03-26T14:07:40Z

@rousseldenis yes I know, so how do you suggest to reduce the commits?

rousseldenis · 2021-03-26T14:08:36Z

@rousseldenis yes I know, so how do you suggest to reduce the commits?

Nope, this will be merged as is, it's ok

eantones · 2021-03-26T14:11:05Z

@rousseldenis ok, so you meant that we cannot do anything now because this should have been done on 14.0 branch creation right?

guewen

Thanks ❤️
Waiting for the build before merging.

guewen · 2021-03-26T14:22:13Z

ok, so you meant that we cannot do anything now because this should have been done on 14.0 branch creation right?

yep

eantones · 2021-03-26T14:24:25Z

Thanks :-)

simahawk · 2021-03-26T14:33:23Z

@guewen @rousseldenis regarding the 721 commits, you're right, there's too many, I can make a squash

There are two ways of doing main branches :

* Creating the branch with no module at all from scratch (actual OCA convention apart some repos). All migration PR are created with the whole commit history like here.

* Creating the new main branch (14.0) based on previous one (13.0). So, the commit history is preserved between them. The advantage is that migration PR would contain only the new commits and is more readable.

Workaround: before submitting a migration PR open another one where the module is ported as is from another version and made uninstallable.

guewen · 2021-03-26T15:00:57Z

/ocabot merge nobump

OCA-git-bot · 2021-03-26T15:01:24Z

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-385-by-guewen-bump-nobump, awaiting test results.

OCA-git-bot · 2021-03-26T16:24:29Z

Congratulations, your PR was merged at 609abb4. Thanks a lot for contributing to OCA. ❤️

guewen · 2021-04-23T18:50:05Z

Hi, I realize that test_component and test_connector add-ons are not included. You may have missed them, but they are what ensure we have no regression

eantones force-pushed the 14.0-mig-connector branch from 8999a01 to 6db7697 Compare October 16, 2020 19:23

eantones mentioned this pull request Oct 19, 2020

Migration to version 14.0 #381

Closed

6 tasks

simahawk reviewed Oct 20, 2020

View reviewed changes

Comment thread test-requirements.txt Outdated

eantones force-pushed the 14.0-mig-connector branch 3 times, most recently from f627d40 to 82d49e7 Compare October 21, 2020 08:05

eantones force-pushed the 14.0-mig-connector branch from 82d49e7 to 8a81c49 Compare December 2, 2020 18:14

eantones force-pushed the 14.0-mig-connector branch 2 times, most recently from d4f31f7 to 8a81c49 Compare December 2, 2020 18:37

guewen reviewed Dec 3, 2020

View reviewed changes

Guewen Baconnier and others added 15 commits March 14, 2021 10:32

Allow to assign a default channel on @job functions

8f08bcc

When the @job is registered and created in the database, it lookups its channel and creates it if it don't exist yet.

[IMP] add attribute 'exported_fields'on Mapper classes to list the ex…

86e3568

…ported fields

[FIX] remove useless print

23c55eb

[ADD] support function on direct fields

a026e2f

[IMP] rename exported_fields to changed_by_fields

e770235

[ADD] comment

0a6b865

See if we can remove install_in_connector() by checking in ir.module.…

2e93aa2

…module with caching of the result

Update doc

aebf3a3

Fix, the method 'module_uninstall' invalid the ormcache of is_module_…

e138d53

…installed

[FIX] change list to set and fix nested direct functions

19113b6

improve comparaison test

f3181c7

[IMP] add tests for _changed_by_fields attribute

2e21a02

[FIX] use staticmethod to keep _mapping_field_name() inside the metac…

dc4466f

…lass

[FIX] _mapping_field_name()

9b1be31

[FIX] useless blank line

4a704ee

rvalyi approved these changes Mar 26, 2021

View reviewed changes

rousseldenis approved these changes Mar 26, 2021

View reviewed changes

OCA-git-bot added the approved label Mar 26, 2021

hparfr approved these changes Mar 26, 2021

View reviewed changes

Remove connector checkpoints

a497da1

Alternatives such as activities can be used.

hparfr mentioned this pull request Mar 26, 2021

[MIG] 14.0 elasticsearch shopinvader/odoo-shopinvader#917

Merged

3 tasks

Merge pull request #1 from guewen/14.0-mig-connector

1e59bcd

Remove connector checkpoints

guewen approved these changes Mar 26, 2021

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Mar 26, 2021

OCA-git-bot merged commit 23477ec into OCA:14.0 Mar 26, 2021

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 26, 2021

guewen mentioned this pull request Apr 24, 2021

[14.0] Migrate test_connector #403

Merged

		from odoo import _, api, fields, models


		class ConnectorCheckpoint(models.Model):

Uh oh!

Uh oh!

Conversation

eantones commented Oct 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eantones commented Oct 16, 2020

Uh oh!

Uh oh!

sebastienbeau commented Dec 2, 2020

Uh oh!

eantones commented Dec 2, 2020

Uh oh!

guewen Dec 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sebastienbeau Dec 3, 2020

Choose a reason for hiding this comment

Uh oh!

kittiu Mar 14, 2021

Choose a reason for hiding this comment

Uh oh!

simahawk Mar 16, 2021

Choose a reason for hiding this comment

Uh oh!

esakarya commented Jan 13, 2021

Uh oh!

kittiu commented Mar 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rvalyi left a comment

Choose a reason for hiding this comment

Uh oh!

rousseldenis left a comment

Choose a reason for hiding this comment

Uh oh!

guewen commented Mar 26, 2021

Uh oh!

guewen commented Mar 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

guewen commented Mar 26, 2021

Uh oh!

eantones commented Mar 26, 2021

Uh oh!

eantones commented Mar 26, 2021

Uh oh!

rousseldenis commented Mar 26, 2021

Uh oh!

rousseldenis commented Mar 26, 2021

Uh oh!

eantones commented Mar 26, 2021

Uh oh!

rousseldenis commented Mar 26, 2021

Uh oh!

eantones commented Mar 26, 2021

Uh oh!

guewen left a comment

Choose a reason for hiding this comment

Uh oh!

guewen commented Mar 26, 2021

Uh oh!

eantones commented Mar 26, 2021

Uh oh!

simahawk commented Mar 26, 2021

Uh oh!

guewen commented Mar 26, 2021

Uh oh!

OCA-git-bot commented Mar 26, 2021

Uh oh!

OCA-git-bot commented Mar 26, 2021

Uh oh!

guewen commented Apr 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

eantones commented Oct 16, 2020 •

edited

Loading

guewen Dec 3, 2020 •

edited

Loading

kittiu commented Mar 14, 2021 •

edited

Loading

guewen commented Mar 26, 2021 •

edited

Loading