Skip to content

Hide http://varnomen.hgvs.org ValueSet errors #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryma2fhir merged 3 commits into from
May 22, 2024
Merged

Hide http://varnomen.hgvs.org ValueSet errors #97

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7d59cb
Update common.js.ts
ryma2fhir May 21, 2024
38f6bf0
Update common.js.ts
ryma2fhir May 21, 2024
db804c9
fix spelling mistake
ryma2fhir May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/common.js.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,8 @@ function raiseWarning(issue: OperationOutcomeIssue, failOnWarning:boolean): bool
}

// THESE WARNINGS SHOULD ALWAYS BE SILENTLY IGNORED
// Issue with GitHub validator requiring code to be in CodeSystem asset when there is none. No issues with the validator itself. The ValueSet in question is https://terminology.hl7.org/5.5.0/CodeSystem-v3-hgvs.html
if (issue.diagnostics.includes('http://varnomen.hgvs.org')) return false

Check failure

Code scanning / CodeQL

Incomplete URL substring sanitization

'[http://varnomen.hgvs.org](1)' can be anywhere in the URL, and arbitrary hosts may come before or after it.
//if (issue.diagnostics.includes('Code system https://dmd.nhs.uk/ could not be resolved.')) return false
// Issue with hapi giving incorrect error when one code is from the valueset, but another is not. See https://github.com/hapifhir/hapi-fhir/issues/4152
if (issue.diagnostics.includes('Inappropriate CodeSystem URL') && issue.diagnostics.includes('for ValueSet: http://hl7.org/fhir/ValueSet/all-languages')) {
Expand Down