Hide http://varnomen.hgvs.org ValueSet errors#97
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ryma2fhir
changed the title
|
|
||
| // THESE WARNINGS SHOULD ALWAYS BE SILENTLY IGNORED | ||
| // Issue with GitHub validator requiring code to be in CodeSystem asset when there is none. No issues with the validator itself. The ValueSet in question is https://terminology.hl7.org/5.5.0/CodeSystem-v3-hgvs.html | ||
| if (issue.diagnostics.includes('http://varnomen.hgvs.org')) return false |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization
KazeemHamzat
approved these changes
May 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hide any errors relating to the codesystem
http://varnomen.hgvs.orgwithin the ValueSethttps://terminology.hl7.org/5.5.0/CodeSystem-v3-hgvs.htmlas the ValueSet is empty but binding isrequired. This is only an issue with the github validation and not the validator itself.This issue can be found in https://github.com/NHSDigital/NHSDigital-FHIR-Genomics-ImplementationGuide/actions/runs/9115457743
received: "ERROR None of the codings provided are in the value set 'Human Genome Variation Society (HGVS) Nomenclature' (http://hl7.org/fhir/uv/genomics-reporting/ValueSet/hgvs-vs|3.0.0-ballot), and a coding from this value set is required) (codes = http://varnomen.hgvs.org#NM_001363118.2:c.916G>A) [ Location - Observation.component[3].value.ofType(CodeableConcept)] [ Location - Line[109] Col[6]] ERROR Validation failed for 'http://varnomen.hgvs.org#NM_001363118.2:c.916G>A' [ Location - Observation.component[3].value.ofType(CodeableConcept).coding[0]] [ Location - Line[110] Col[8]]"