Update deps enhancements#8705
Conversation
|
Author MathiasMagnus not on autobuild list. Waiting for curator authorization before starting CI build. |
MathiasMagnus
force-pushed
the
update-deps-enhancements
branch
from
1c2e841 to
7bc5fb3
Compare
|
Author MathiasMagnus not on autobuild list. Waiting for curator authorization before starting CI build. |
MathiasMagnus
force-pushed
the
update-deps-enhancements
branch
from
7bc5fb3 to
69638b4
Compare
|
Author MathiasMagnus not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author MathiasMagnus not on autobuild list. Waiting for curator authorization before starting CI build. |
Without going through an intricate dance with git to change the remote URL of a repository, it's simplest to just nuke the cloned folder, as we have to do a clean clone anyway.
The documentation states that users can override where to take a dependency from via variables like VULKAN_HEADERS_INSTALL_DIR, however the helper.cmake written by the scripts/CMakeLists.txt FORCE updates the cache variable to the location inside known_good.json, practically overwriting the user-provided path given on the CLI using -D, also going into the cache.
MathiasMagnus
force-pushed
the
update-deps-enhancements
branch
from
4b399d8 to
a947b79
Compare
|
Author MathiasMagnus not on autobuild list. Waiting for curator authorization before starting CI build. |
|
By the way, has LunarG considered externalizing all the build related utilities to a dedicated repository? This way it would be easier to propagate changes to all the repositories, but the biggest gain would be to have a dedicated place where the utility scripts could be tested (for eg. if the repo URL is changed, can one rerun |
spencer-lunarg
left a comment
spencer-lunarg
left a comment
There was a problem hiding this comment.
LGTM
@charles-lunarg any objections?
something to be aware of is unfortunately this update_deps.py is a example of copy-and-paste gone wrong and you may want to upstream fixes everywhere else
Yes, we have considered and very aware of the problem, I think the issue is just having someone spend the engineering hours going around and updating things and making sure they break everyone as they are doing it |
4 participants
This PR contains fixes to two annoyances of ours, both arguably bug candidates:
update_deps.py, which can easily be handled by wiping the clone dir.XYZ_INSTALL_DIRvariables can be used to override where dependencies should be taken from, but the dep fetching machinery outright overwrites all user-provided paths.