Update deps enahancements#1044
Merged
charles-lunarg merged 2 commits intoOct 28, 2024
Merged
Conversation
Without going through an intricate dance with git to change the remote URL of a repository, it's simplest to just nuke the cloned folder, as we have to do a clean clone anyway.
The documentation states that users can override where to take a dependency from via variables like VULKAN_HEADERS_INSTALL_DIR, however the helper.cmake written by the scripts/CMakeLists.txt FORCE updates the cache variable to the location inside known_good.json, practically overwriting the user-provided path given on the CLI using -D, also going into the cache.
|
Author MathiasMagnus not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author MathiasMagnus not on autobuild list. Waiting for curator authorization before starting CI build. |
charles-lunarg
approved these changes
Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR propagates these changes from the VVL.