Skip to content

refactor(genai): migrate region tags from generative-ai to genai folder (Batch 2)#4336

Merged
iennae merged 1 commit into
mainfrom
refactor/region-tags-generativeai-to-genai-batch2
Jun 9, 2026
Merged

refactor(genai): migrate region tags from generative-ai to genai folder (Batch 2)#4336
iennae merged 1 commit into
mainfrom
refactor/region-tags-generativeai-to-genai-batch2

Conversation

@angelcaamal

@angelcaamal angelcaamal commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes Internal: b/521840826

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@angelcaamal angelcaamal added samples Issues that are directly related to samples. generated: genai Contains Generative AI based code, requesting an additional reviewer. labels Jun 9, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Google Gen AI SDK code samples by adding new region tags for Vertex AI Gemini features (such as safety settings, multi-turn chat, video, and content generation) across various sample files. Additionally, several obsolete standalone sample files and their associated test files have been removed. There are no review comments, so no feedback is provided.

@angelcaamal angelcaamal marked this pull request as ready for review June 9, 2026 16:35
@angelcaamal angelcaamal requested review from a team as code owners June 9, 2026 16:35
@snippet-bot

snippet-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown
You are about to delete the following sample browser page.

Here is the summary of changes.

You are about to add 11 region tags.
You are about to delete 11 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@iennae iennae merged commit 7517761 into main Jun 9, 2026
27 checks passed
@iennae iennae deleted the refactor/region-tags-generativeai-to-genai-batch2 branch June 9, 2026 17:34
iennae pushed a commit that referenced this pull request Jun 9, 2026
…nai folder (Batch 1)" (#4339)

* Revert "refactor(genai): migrate region tags from generative-ai to genai folder (Batch 2) (#4336)"

This reverts commit 7517761.

* Revert "refactor(genai): migrate region tags from generative-ai to genai folder (Batch 1) (#4335)"

This reverts commit f2465a6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: genai generated: genai Contains Generative AI based code, requesting an additional reviewer. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants