refactor(genai): migrate region tags from generative-ai to genai folder (Batch 1)#4335
Conversation
There was a problem hiding this comment.
Code Review
This pull request consolidates GenAI sample files by adding new region tags (such as generativeaionvertexai_gemini_token_count and generativeaionvertexai_gemini_system_instruction) to existing JavaScript files under the genai/ directory. Concurrently, it removes several redundant standalone sample files and their associated mocha test files. There are no review comments to address, so I have no feedback to provide.
|
Here is the summary of changes. You are about to add 10 region tags.
You are about to delete 10 region tags.
This comment is generated by snippet-bot.
|
|
|
||
| 'use strict'; | ||
|
|
||
| // [START generativeaionvertexai_gemini_translate] |
There was a problem hiding this comment.
General question, is it ok to have a double region tag reference for one code snippet?
There was a problem hiding this comment.
more than one region tag can refer to the same code snippet.
additionally, you can have start/end multiple times in the same file. You should not have the same region tag in the same repo in different files.
Description
Fixes Internal: b/520504837
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.