Skip to content

test(debugger): detect bracketed byteLength at runtime #8172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BridgeAR merged 1 commit into from
Apr 29, 2026
Merged

test(debugger): detect bracketed byteLength at runtime #8172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions integration-tests/debugger/template.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
'use strict'

const assert = require('node:assert/strict')
const semver = require('semver')
const { inspect } = require('node:util')
const { NODE_MAJOR } = require('../../version')
const { setup } = require('./utils')

const NODE_24_11_1_OR_LATER = semver.gte(process.version, '24.11.1')
// Backported across LTS lines, so detect at runtime instead of version-gating.
const HAS_BRACKETED_BYTELENGTH = inspect(new ArrayBuffer(0)).includes('[byteLength]')

describe('Dynamic Instrumentation', function () {
describe('template evaluation', function () {
Expand Down Expand Up @@ -100,7 +101,7 @@ describe('Dynamic Instrumentation', function () {
messages.shift(),
'ArrayBuffer { ' +
'[Uint8Contents]: <00 00 00 ... 7 more bytes>, ' +
(NODE_24_11_1_OR_LATER ? '[byteLength]' : 'byteLength') +
(HAS_BRACKETED_BYTELENGTH ? '[byteLength]' : 'byteLength') +
": 10, '0': 0, '1': 1, '2': 2, '3': 3, '4': 4, '5': 5, '6': 6, '7': 7, '8': 8, '9': 9 " +
'}'
)
Expand Down
Loading