test(debugger): detect bracketed byteLength at runtime - #8172
Merged
BridgeAR merged 1 commit intoApr 29, 2026
Merged
Conversation
Contributor
Overall package sizeSelf size: 5.67 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.1 | 82.56 kB | 817.39 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 72c3900 | Docs | Datadog PR Page | Give us feedback! |
The template integration test compared its output against a hardcoded `util.inspect` string and version-gated the bracketed `[byteLength]` form on `>=24.11.1`. The same change was later backported to Node.js v22.22.1, which broke `node-active` on master once GitHub Actions started serving v22.22.x to that job (PR CI happened to land on v22.22.0 and stayed green). Probe the current `util.inspect` output for `[byteLength]` instead, so the assertion tracks Node's actual behavior on whatever patch the runner picks up. This avoids having to enumerate every release line that backports the change. Refs: nodejs/node#60131
BridgeAR
force-pushed
the
BridgeAR/2026-04-29-fix-debugger-template-byte-length-test
branch
from
April 29, 2026 16:39
e208ce7 to
72c3900
Compare
watson
approved these changes
Apr 29, 2026
BridgeAR
enabled auto-merge (squash)
April 29, 2026 17:01
BenchmarksBenchmark execution time: 2026-04-29 17:09:04 Comparing candidate commit 72c3900 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1344 metrics, 100 unstable metrics. |
BridgeAR
deleted the
BridgeAR/2026-04-29-fix-debugger-template-byte-length-test
branch
April 29, 2026 17:10
dd-octo-sts Bot
pushed a commit
that referenced
this pull request
Apr 29, 2026
The template integration test compared its output against a hardcoded `util.inspect` string and version-gated the bracketed `[byteLength]` form on `>=24.11.1`. The same change was later backported to Node.js v22.22.1, which broke `node-active` on master once GitHub Actions started serving v22.22.x to that job (PR CI happened to land on v22.22.0 and stayed green). Probe the current `util.inspect` output for `[byteLength]` instead, so the assertion tracks Node's actual behavior on whatever patch the runner picks up. This avoids having to enumerate every release line that backports the change. Refs: nodejs/node#60131 Refs: #8140
Merged
BridgeAR
added a commit
that referenced
this pull request
Apr 30, 2026
The template integration test compared its output against a hardcoded `util.inspect` string and version-gated the bracketed `[byteLength]` form on `>=24.11.1`. The same change was later backported to Node.js v22.22.1, which broke `node-active` on master once GitHub Actions started serving v22.22.x to that job (PR CI happened to land on v22.22.0 and stayed green). Probe the current `util.inspect` output for `[byteLength]` instead, so the assertion tracks Node's actual behavior on whatever patch the runner picks up. This avoids having to enumerate every release line that backports the change. Refs: nodejs/node#60131 Refs: #8140
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The template integration test version-gates the bracketed
[byteLength]form ofutil.inspect(new ArrayBuffer(...))on>=24.11.1. That same change (nodejs/node#60131) was backported to v22.22.1, so thenode-activejob (Node 22.x) onmasterstarted failing as soon as the runner served v22.22.x. PR CI for #8140 was cached on v22.22.0 and stayed green; the post-merge run resolved v22.22.2 and tripped:Probe
util.inspect(new ArrayBuffer(0))for[byteLength]at runtime so the assertion follows the actual format on whatever patch the runner picks up. No more enumerating release lines as further backports land.Refs: https://github.com/DataDog/dd-trace-js/actions/runs/25119400932/job/73618598749
Refs: nodejs/node#60131
Refs: #8140